[codex] Fix generated password validation#1196
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a mismatch between generated/documented password characters and the actual validation logic by updating both frontend and backend validators to accept ^ and ?, and adds backend unit test coverage for those symbols.
Changes:
- Expand the allowed-character regex in both frontend and backend password validators to include
^and?. - Add backend unit tests verifying passwords containing
^and?are accepted.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/hooks/usePasswordValidation.ts | Updates the client-side validation regex to accept ^ and ? to match the documented allowed set. |
| backend/src/utils/validatePassword.ts | Updates server-side validation regex (and keeps the error text aligned) to accept ^ and ?. |
| backend/src/unit-tests/validatePassword.test.ts | Adds unit tests to ensure passwords containing ^ and ? validate successfully. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^and?.Root Cause / Context
The admin user modal can generate passwords using
^and?, and both frontend/backend messages said those characters were allowed. The actual validation regex on both sides omitted them, so generated or manually-set admin passwords containing those characters were rejected.Validation
cd backend && npx jest src/unit-tests/validatePassword.test.ts --runInBand --config jest-config.jsnpm run lint:backendnpm run lint:frontendnpm run tsc:backendnpm run tsc:frontendnpm run lintand rootnpm run tscsuccessfully.Closes #730