Skip to content

feat: adds cookie to redaction list #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reggi merged 3 commits into from
Apr 21, 2025
Merged

feat: adds cookie to redaction list #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad66466
fix(server): redactThrow should return function
reggi Jan 29, 2025
0fb1b4a
redacts cookie header
reggi Apr 21, 2025
55a1aa6
merge
reggi Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/matchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ const DEEP_HEADER_SET_COOKIE = {
replacement: '[REDACTED_HEADER_SET_COOKIE]',
}

const DEEP_HEADER_COOKIE = {
type: TYPE_PATH,
predicate: ({ path }) => path.endsWith('.headers.cookie'),
replacement: '[REDACTED_HEADER_COOKIE]',
}

const REWRITE_REQUEST = {
type: TYPE_PATH,
predicate: ({ path }) => path.endsWith('.request'),
Expand Down Expand Up @@ -76,6 +82,7 @@ module.exports = {
URL_MATCHER,
DEEP_HEADER_AUTHORIZATION,
DEEP_HEADER_SET_COOKIE,
DEEP_HEADER_COOKIE,
REWRITE_REQUEST,
REWRITE_RESPONSE,
}
2 changes: 2 additions & 0 deletions lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const {
DEEP_HEADER_SET_COOKIE,
REWRITE_REQUEST,
REWRITE_RESPONSE,
DEEP_HEADER_COOKIE,
} = require('./matchers')

const {
Expand All @@ -24,6 +25,7 @@ const _redact = redactMatchers(
JSON_WEB_TOKEN,
DEEP_HEADER_AUTHORIZATION,
DEEP_HEADER_SET_COOKIE,
DEEP_HEADER_COOKIE,
REWRITE_REQUEST,
REWRITE_RESPONSE,
redactUrlMatcher(
Expand Down
14 changes: 14 additions & 0 deletions test/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,17 @@ t.test('serialize a redactError', async t => {
t.same(goodError.stack, badError.stack, 'should serialize stack')
t.same(serialized.sensitive, undefined, 'should not serialize sensitive data')
})

t.test('readcts header.cookie', async t => {
const input = {
headers: {
cookie: examples.COOKIE,
},
}
const output = redact(input)
t.same(output, {
headers: {
cookie: matchers.DEEP_HEADER_COOKIE.replacement,
},
})
})
Loading