chore: adds codeql workflow#43
Merged
Merged
Conversation
owlstronaut
approved these changes
May 2, 2025
Merged
reggi
pushed a commit
that referenced
this pull request
May 2, 2025
🤖 I have created a release *beep* *boop* --- ## [3.2.1](v3.2.0...v3.2.1) (2025-05-02) ### Bug Fixes * [`2aca0ac`](2aca0ac) [#42](#42) check if Buffer is available (#42) (@reggi) ### Chores * [`40f41d9`](40f41d9) [#43](#43) adds codeql workflow (#43) (@reggi) * [`ce4294a`](ce4294a) [#41](#41) bumping @npmcli/template-oss from 4.23.3 to 4.24.3 (#41) (@owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Shouldn't templateoss have done this? https://github.com/npm/template-oss/blob/21fa419c1d53e60f3e28ce566d5942da9a06d88a/lib/content/codeql-analysis-yml.hbs |
|
Yeah, how is this different than https://github.com/npm/redact/blob/main/.github/workflows/codeql-analysis.yml? Why do we need two of them? |
hashtagchris
reviewed
May 4, 2025
Comment on lines
+1
to
+2
| # For most projects, this workflow file will not need changing; you simply need | ||
| # to commit it to your repository. |
Contributor
There was a problem hiding this comment.
Did we tweak anything, or commit as generated?
Is this intended to replace the dynamic workflow runs? What's the motivation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References