acl: add comment field to EACL records#401
Open
End-rey wants to merge 1 commit into
Open
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 20, 2026 13:40
Closes #400. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
| repeated Target targets = 4 [json_name = "targets"]; | ||
|
|
||
| // Optional auxiliary data associated with the rule. The comment does not | ||
| // affect permission evaluation and must be valid UTF-8. |
Member
There was a problem hiding this comment.
... without zero bytes
Just to remind, 0x00 is a valid UTF-8 character, but we never want that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400.