perf(sift): exclude inlined WASM from renderer plugin (7.4 MB -> 382 kB)#2136
Merged
Conversation
…-> 382 kB)
The wasm-bindgen glue contains new URL('sift_wasm_bg.wasm', import.meta.url)
which Vite base64-inlines into the JS bundle. The sift renderer already
loads the WASM from the blob server via setWasmUrl(), so the 6.9 MB
inline copy was never used. A build plugin now rewrites the URL reference
to prevent the inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new URL('sift_wasm_bg.wasm', import.meta.url)which Vite base64-inlines into the CJS bundle. The 5.2 MB WASM binary expands to 6.9 MB of base64, making the sift.js plugin 7.4 MB.setWasmUrl(), so the inline copy was never used.Test plan
🪶 Generated with Quill Agent