feat(taco): Add nestedAbiDecode schema for selectorless ABI validation#766
Draft
theref wants to merge 303 commits intonucypher:signing-epicfrom
Draft
feat(taco): Add nestedAbiDecode schema for selectorless ABI validation#766theref wants to merge 303 commits intonucypher:signing-epicfrom
theref wants to merge 303 commits intonucypher:signing-epicfrom
Conversation
- change signUserOp method to use 'data' instead of 'params' for POST request - aligns with other Porter methods that send data in request body - fixes 400 Bad Request error when signing user operations
- update test expectations to match new base64-encoded signing request format - tests now expect btoa(JSON.stringify(...)) instead of JSON.stringify(...)
- change signing request structure to match Python implementation - use snake_case field names (cohort_id, chain_id, signature_type) - serialize userOp as 'data' field instead of direct embedding - update tests to match new request format
- Use sorted JSON keys for user operations to match Python implementation - Update signing request structure with proper field names - Add error logging for debugging Porter API responses - Update tests to match new request format
- Add UserOperation type, UserOperationSignatureRequest class, and convertUserOperationToPython utility to shared/src/types.ts - Export new types and classes in shared/src/index.ts - Update taco/src/types.ts to re-export UserOperation from shared package - Eliminates duplication of UserOperation type definitions across packages
- Fix Porter client to use POST data instead of query params for /sign endpoint - Fix SigningCoordinator.getThreshold() to use signingCohorts(cohortId).threshold - Update signUserOp() to use shared conversion utilities and proper base64 encoding - Update tests to use shared conversion function and correct signature_type 'userOp' - Remove console.log statements and simplify integration test - All functionality now uses centralized types from shared package
- Updated SignResponse type to match new API response format with separated signatures and errors - Enhanced PorterClient.sign() with better error handling and response structure validation - Added debug logging to signing integration test - Fixed signer key mapping from operator to provider in signUserOp - Removed debug code for porter ursulas endpoint
- Remove private key security risk and use dummy address - Switch to Ethereum Sepolia testnet (chain ID 11155111) - Update RPC provider URL to publicnode.com - Change ritual ID to 1 - Fix test skip condition for CI environment
- Fix UserOperationSignatureRequest constructor to accept objects instead of strings - Remove double JSON stringification that caused address encoding errors - Update convertUserOperationToPython to handle null/empty values properly - Fix test expectations to match new data format and provider addresses - Resolve AddressEncoder errors by ensuring proper hex address format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update test expectations to use JSON.stringify for user_op field serialization - Rename digest field to messageHash in SignResult interface and all related code - Implement strict address validation that fails fast on invalid checksums - Fix Porter test mock response structure to match API format - Update integration test to use properly checksummed addresses Co-Authored-By: Kieran <kieranprasch@gmail.com>
…pt pattern - Remove complex try-catch blocks and manual error checking in signUserOp - Use direct destructuring of errors from Porter response - Trust Porter's response structure instead of adding validation overhead - Update tests to match new error handling pattern - Follow same approach as tacoDecrypt for consistent error handling
- Add async forSigningCohort static method to build context from signing cohort conditions - Fix import ordering and add missing ethers import - Update integration test to use new signing context method with await
- Add tests for happy path scenario with valid cohort conditions - Add error handling tests for network failures and invalid responses - Add tests for invalid hex decoding and JSON parsing errors - Add tests for complex compound condition structures - Add tests for invalid condition schema validation - Fix hex decoding in forSigningCohort method to handle contract responses
…ash validation - Remove returnAggregated option from SigningOptions type - Remove unused options parameter from signUserOp method - Add validation to ensure all Ursulas return same message hash - Throw error if message hashes don't match across signatures
…ash validation test - Remove returnAggregated options from existing tests - Add test case to verify error thrown when message hashes don't match - Update test calls to match new signUserOp signature
…erface - Remove SigningOptions import as no longer needed - Remove options parameter from signUserOp function signature - Update porter.signUserOp call to remove options parameter
- Remove unused INTERNAL_SIGNING_CONDITION constant - Update RESERVED_CONTEXT_PARAMS to only include USER_ADDRESS_PARAM_DEFAULT
- Remove returnAggregated options from test calls - Update function calls to match new signUserOp signature - Remove unused options variable from test
- Remove returnAggregated option from signUserOp call in integration test
- Change aggregation logic from length > 0 to length >= threshold - Ensures aggregated signature only provided with sufficient signatures
- Fix existing test expectation for insufficient signatures case - Add new test to verify no aggregation when threshold not met - Ensure test coverage for both threshold met and unmet scenarios
- Remove throw for mismatched message hashes - Include signature processing errors in result errors instead - Add try-catch for signature decoding failures - Continue processing other signatures when one fails - Let caller decide how to handle errors based on SignResult
- Change mismatched hash test to expect error in result instead of thrown - Verify result contains partial signatures and error details - Test that processing continues with valid signatures despite errors
- Add SigningOptions parameter with optimistic flag - Extract signature decoding logic to eliminate duplication - Optimistic mode: skip hash validation, use all signatures - Non-optimistic mode: validate hashes, only aggregate when threshold+ nodes agree - All signatures included in signingResults regardless of mode - Add comprehensive test coverage for new optimistic signing logic - Update existing test expectations for new signing behavior
Run pnpm fix.
Remove OBJECT_VALUE_OPERATIONS exclusion list so create2 is covered by the regression backstop test for operations requiring a value. Use toContain assertion since create2 produces multiple errors.
…ema and the create2 operation schema. Revert change to test since no longer needed.
Add parametrized test ensuring all non-unary, non-create2 operations reject create2-shaped object values.
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Caches getParticipants and getThreshold results with a 10-second TTL to avoid redundant contract reads during short time windows. Cache is keyed by domain and cohortId, with a public clearCache() method for manual invalidation. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Covers cache hits, TTL expiry, per-domain and per-cohortId isolation, and manual cache clearing. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Move cache logic from SigningCoordinatorAgent into a reusable TtlCache class. Bump TTL from 10s to 60s per review feedback. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Reorder cache keys from field:domain:cohortId to domain:cohortId:field (broader to specific) and extract a cacheKey() helper to keep key structure consistent, per review feedback.
Replace ':nullAddress' string literals with NULL_ADDRESS_CONTEXT_VAR constant defined in conditions/const.ts, used in both AUTOMATICALLY_INJECTED_CONTEXT_PARAMS and RESERVED_CONTEXT_PARAMS.
Replace Buffer.from(...).toString('hex') with the existing toHexString
utility from @nucypher/shared for consistency with the rest of the
codebase.
…dices Idiomatic TypeScript prefers undefined over null for absent values. Addresses PR review feedback.
Add abiDecodeValidationSchema and update abiParameterValidationSchema to support a third option alongside returnValueTest and nestedAbiValidation. Used for ERC-7579 batch execution payloads.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## signing-epic #766 +/- ##
===============================================
Coverage ? 90.82%
===============================================
Files ? 98
Lines ? 8673
Branches ? 568
===============================================
Hits ? 7877
Misses ? 752
Partials ? 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
derekpierre
force-pushed
the
signing-epic
branch
from
5e72a50 to
a6efe66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
abiDecodeValidationSchemaand updateabiParameterValidationSchemato support a third option alongsidereturnValueTestandnestedAbiValidation. Used for batch execution payloads.The real work is in nucypher/nucypher#3723