Repository navigation
fix(strategy): emit task type for reduce step - #47
Merged
vernonstinebaker merged 1 commit intoSep 28, 2026
Merged
Conversation
buildReduceStep wrapped the user reduce block as type:"reduce", but StepType has no reduce variant, so validateStepsForCreateRun rejected the expanded steps with StepTypeUnknown -> HTTP 400 "unknown step type" for any parallel+reduce workflow. A reduce block is conceptually a synthesis task with implicit depends_on (already built by the expander). Emit type:"task"; no engine changes needed. Avoids bloating StepType with a strategy-specific concept. Regression test: expandStrategy(parallel+reduce) output now passes validateStepsForCreateRun cleanly. Fixes nullclaw#33
vernonstinebaker
approved these changes
Sep 28, 2026
vernonstinebaker
left a comment
vernonstinebaker
left a comment
Contributor
There was a problem hiding this comment.
Clean fix for #33: a reduce block is a synthesis task with implicit depends_on (already built by the expander), so type: "task" is correct and avoids polluting StepType with a strategy-only concept. Best part is the regression test — the expanded steps now round-trip through validateStepsForCreateRun, which is exactly where the old type: "reduce" died with StepTypeUnknown. CI green, scope confined to strategy.zig. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
buildReduceStepwrapped the user reduce block astype:"reduce", butStepTypehas noreducevariant, sovalidateStepsForCreateRunrejected the expanded steps withStepTypeUnknown→ HTTP 400"unknown step type"for anyparallel+reduceworkflow.A reduce block is conceptually a synthesis task with implicit
depends_on(already built by the expander). Emittype:"task"; no engine changes needed. Avoids bloatingStepTypewith a strategy-specific concept.Regression test:
expandStrategy(parallel+reduce)output now passesvalidateStepsForCreateRuncleanly. Full suite green (zig build test, 356/356).