Skip to content

MAINT: Fix two cases of code injection via template expansion #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agriyakhetarpal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MAINT: Fix two cases of code injection via template expansion #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ jobs:

- name: pkg-config-for-win
if: runner.os == 'windows'
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
run: |
choco install -y --no-progress --stoponfirstfailure --checksum 6004DF17818F5A6DBF19CB335CC92702 pkgconfiglite
$CIBW = "${{ github.workspace }}/.openblas"
$CIBW = "$env:GITHUB_WORKSPACE/.openblas"
# pkgconfig needs a complete path, and not just "./openblas since the
# build is run in a tmp dir (?)
# It seems somewhere in the env passing, `\` is not
Expand All @@ -113,14 +115,16 @@ jobs:

- name: Setup macOS
if: startsWith(matrix.buildplat[0], 'macos')
env:
BLAS_BACKEND: ${{ matrix.buildplat[2] }}
run: |
# Needed due to https://github.com/actions/runner-images/issues/3371
# Supported versions: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md
echo "FC=gfortran-15" >> "$GITHUB_ENV"
echo "F77=gfortran-15" >> "$GITHUB_ENV"
echo "F90=gfortran-15" >> "$GITHUB_ENV"

if [[ ${{ matrix.buildplat[2] }} == 'accelerate' ]]; then
if [[ "$BLAS_BACKEND" == 'accelerate' ]]; then
# Builds with Accelerate only target macOS>=14.0
echo "CIBW_ENVIRONMENT_MACOS=MACOSX_DEPLOYMENT_TARGET=14.0 INSTALL_OPENBLAS=false" >> "$GITHUB_ENV"
else
Expand Down