Skip to content

[17.0][OU-FIX] openupgrade_framework: tolerate field type changes in _process_ondelete #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eantones wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][OU-FIX] openupgrade_framework: tolerate field type changes in _process_ondelete #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions openupgrade_framework/odoo_patch/odoo/addons/base/models/ir_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
from openupgradelib import openupgrade

from odoo import api, models
from odoo import api, fields, models

from odoo.addons.base.models.ir_model import (
IrModel,
Expand Down Expand Up @@ -74,14 +74,22 @@ def _module_data_uninstall(self):


def _process_ondelete(self):
"""Don't break on missing models when deleting their selection fields"""
"""Don't break on missing models, missing fields or fields that are no
longer Selection fields when deleting their selection values"""
to_process = self.browse([])
for selection in self:
try:
self.env[selection.field_id.model] # pylint: disable=pointless-statement
to_process += selection
model = self.env[selection.field_id.model]
except KeyError:
continue
field = model._fields.get(selection.field_id.name)
if field is None or not isinstance(field, fields.Selection):
# The field vanished or changed type between versions (e.g.
# selection -> boolean, or reference-field selection rows that
# became orphans): the ondelete machinery no longer applies,
# just let the record be unlinked.
continue
to_process += selection
return IrModelSelection._process_ondelete._original_method(to_process)


Expand Down
Loading