-
Notifications
You must be signed in to change notification settings - Fork 547
Implement page search URL + Opensearch XML #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ian-h-chamberlain
wants to merge
2
commits into
nushell:main
Choose a base branch
from
ian-h-chamberlain:feat/search-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <template> | ||
| <DocSearch :options="docsearchOptions" /> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { DocSearch, DocSearchOptions } from '@vuepress/plugin-docsearch/client'; | ||
| import { useDebounceFn, useEventListener } from '@vueuse/core'; | ||
| import { onMounted, Ref, ref } from 'vue'; | ||
| import { useRouter, useRoute } from 'vue-router'; | ||
|
|
||
| const SEARCH_KEY = 'search'; | ||
| const docsearchOptions: Ref<DocSearchOptions> = ref({}); | ||
| const router = useRouter(); | ||
| const route = useRoute(); | ||
|
|
||
| // Handle initial search query, if one is set | ||
| onMounted(() => { | ||
| const query = new URL(window.location.href).searchParams.get(SEARCH_KEY); | ||
| if (query) { | ||
| docsearchOptions.value.initialQuery = query; | ||
| (document.querySelector('.DocSearch-Button') as HTMLButtonElement).click(); | ||
| } | ||
| }); | ||
|
|
||
| // There's some debounce builtin to docsearch, this mimics that and should | ||
| // help prevent browser history from getting filled with partial queries. | ||
| const inputHandler = useDebounceFn(handleSearchInput, 500); | ||
| useEventListener('input', (event) => inputHandler(event as InputEvent)); | ||
|
|
||
| // Update the URL bar when the search input changes. | ||
| function handleSearchInput(event: InputEvent) { | ||
| const target = event.target as HTMLInputElement | undefined; | ||
| const searchQuery = target?.value; | ||
| if (target?.id !== 'docsearch-input' || !searchQuery) { | ||
| return; | ||
| } | ||
|
|
||
| // If we had already started a search, replace it instead of appending | ||
| const { path, query: routeQuery } = route; | ||
| const replace = routeQuery?.hasOwnProperty(SEARCH_KEY); | ||
| const query = { ...routeQuery }; // NOTE: must copy the query object | ||
| query[SEARCH_KEY] = searchQuery; | ||
|
|
||
| router.push({ path, query: { ...query }, replace }); | ||
| } | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <OpenSearchDescription | ||
| xmlns="http://a9.com/-/spec/opensearch/1.1/" | ||
| xmlns:moz="http://www.mozilla.org/2006/browser/search/" | ||
| > | ||
| <ShortName>Nushell Docs</ShortName> | ||
| <Description>Search Nushell documentation</Description> | ||
| <InputEncoding>UTF-8</InputEncoding> | ||
| <Image width="16" height="16" type="image/png">https://www.nushell.sh/icon.png</Image> | ||
| <Url type="text/html" template="https://www.nushell.sh/?search={searchTerms}" /> | ||
| <Url type="application/opensearchdescription+xml" rel="self" template="https://www.nushell.sh/opensearch.xml" /> | ||
| <!-- TODO: it might be possible to provide suggestions via some Algolia API? --> | ||
| </OpenSearchDescription> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think If the input value is empty it's better to delete the search param here. Returning early when the input is cleared means the existing
?search=parameter is not removed. As a result, after the user clears the search and closes the modal, the URL may still retains the old query.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good point, I think that probably makes sense. I'm not sure how easy it will be to detect the modal being dismissed (since that logic is implemented in a nested child), but it's probably doable with some kind of global event listener at least.
I will try to get to implementing this next week when I should have some time!