fix: validate xlink:href and fix data:text/html prefix check in sanitizer#491
Merged
Merged
Conversation
added 2 commits
June 21, 2026 17:53
…rl.href - Add xlinkhref to validateProp href/src check so SVG anchor xlink:href attributes are validated (CVE sibling of href=javascript:) - Change isAnchorLinkAllowed to compare unsafeLinkPrefix against url.href instead of url.protocol so data:text/html entries in the deny-list are actually matched instead of being dead code (protocol is only "data:" for any data URI)
Contributor
Author
|
Waiting for @farnabaz review. |
commit: |
farnabaz01
force-pushed
the
fix/sanitizer-bypass
branch
from
e70d432 to
880caba
Compare
farnabaz
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bypasses in the HTML sanitizer:
Fixed: check xlinkhref in validateProp, compare url.href instead of url.protocol.
All 54 existing tests pass. Added 4 new regression tests.