fix: sanitize root component tags and props from markdown frontmatter#492
Open
farnabaz01 wants to merge 2 commits into
Open
fix: sanitize root component tags and props from markdown frontmatter#492farnabaz01 wants to merge 2 commits into
farnabaz01 wants to merge 2 commits into
Conversation
The frontmatter component field bypassed dangerous-tag and unsafe-prop
checks that exist for child nodes, creating an XSS sink.
Payload example:
---
component:
name: iframe
props:
srcdoc: "<script>...</script>"
---
Fix:
- Reject dangerous root tags (script, base, iframe) by falling back to div
- Apply validateProps to root component props from frontmatter (blocks
srcdoc, formaction, on* event handlers, unsafe href/src)
farnabaz01
force-pushed
the
fix/xss-root-frontmatter
branch
from
4431fcb to
9487d36
Compare
Contributor
Author
|
This PR is ready for review by @farnabaz. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Frontmatter
componentfield was merged directly into renderer data and used to select the root element and its props, bypassing thedangerous-tagandunsafe-propchecks that exist for child nodes.Fix
script,base,iframe) by falling back todivvalidatePropsto root component props from frontmatter (blockssrcdoc,formaction,on*event handlers, unsafehref/src)Tests
validatePropssanitization of srcdoc and unsafe tags