Speech dictionaries dialog. Added a context menu to the dicts list#20424
Speech dictionaries dialog. Added a context menu to the dicts list#20424amirmahdifard wants to merge 9 commits into
Conversation
cary-rowen
left a comment
There was a problem hiding this comment.
It's just a minor issue with the documentation.
83ae934 to
0b2dade
Compare
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
…le, And updated the correct spelling changelog entri
|
@cary-rowen done! thanks! I very liked your suggestion. In addon store, we are forced to open context menu with every action, but here, when we can edit an existing rule, it's the best place for it. I Also implemented delete key shortcut to remove a rule to also be consistent with other dialogs I've Added context menu and shortcut support for. Thanks! |
|
@seanbudd thanks. When I was applying suggested change from review, I didn't figger out this user gide duplicate lines bug. |
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
|
@seanbudd thanks! done! |
Link to issue number:
fixes #20420
Summary of the issue:
the Speech dictionaries list item actions could only be managed by the buttons. Like many other windows dialogs, Also added context menu to this list, so users can use both, whatever they are comftable with
Description of user facing changes:
A context menu has been added to the entries list of the Speech dictionaries dialog and can be opened that has edit, and remove options in it. No other interface changes.
Description of developer facing changes:
none
Description of development approach:
Added a context menu method, Added translater comments, and bound the context menu evt to dict list
Testing strategy:
opened Speech dictionaries dialog, Added edited and removed entries, made sure that both buttons and context menu are functional as before, And also made sure other used keys will continue to act as before and nothing extra is touched and changed
Known issues with pull request:
none
Code Review Checklist: