Skip to content

Add parallel to speed up workflow execution#20490

Open
wmhn1872265132 wants to merge 6 commits into
nvaccess:masterfrom
wmhn1872265132:try-parallel
Open

Add parallel to speed up workflow execution#20490
wmhn1872265132 wants to merge 6 commits into
nvaccess:masterfrom
wmhn1872265132:try-parallel

Conversation

@wmhn1872265132

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Currently, all steps in each job of the GitHub Actions build workflow run sequentially. An unsigned build on the master branch takes approximately 24 minutes.

Description of user facing changes:

None

Description of developer facing changes:

Speed up the GitHub Actions workflow. Unsigned builds now take approximately 21 minutes, and the performance improvement for signed builds is likely to be even more noticeable.

Description of development approach:

According to the GitHub documentation, certain steps have been configured to run in parallel, such as:

  • Checking out the repository and installing Python
  • Restoring cache and installing Python
  • Building the NVDAController client and the launcher simultaneously
  • Installing uv and test software simultaneously

In addition, since actionlint reports errors for this syntax, an ignore configuration has been added.

Testing strategy:

https://github.com/wmhn1872265132/NVDA/actions/runs/29223610846

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@wmhn1872265132 wmhn1872265132 requested a review from a team as a code owner July 13, 2026 06:10
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jul 13, 2026
Comment thread .github/actionlint.yml
@@ -0,0 +1,4 @@
paths:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is actionlint? what is triggering the error?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool was added in #19688

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we wait until rhysd/actionlint#694 is merged and update actionlint instead.

@amirmahdifard

Copy link
Copy Markdown
Contributor

will this also fix a bug where sometimes workflos fale and time out for no reason? i.e last time when I made a change and pushed to my personal branch and waited to get the build artifakt, the workflo faled 2 times and didn't upload anything, I had to rerun jobs 2 times to finally get my build artifakt. This timeout happens randomly even if there are no errors and everything is perfectly fine. Github actions builds has became a serious pick for me, because I can have the possibility to build and test changes without needing to do everything locally. It's a best thing in existence!

@wmhn1872265132

Copy link
Copy Markdown
Contributor Author

will this also fix a bug where sometimes workflos fale and time out for no reason? i.e last time when I made a change and pushed to my personal branch and waited to get the build artifakt, the workflo faled 2 times and didn't upload anything, I had to rerun jobs 2 times to finally get my build artifakt. This timeout happens randomly even if there are no errors and everything is perfectly fine. Github actions builds has became a serious pick for me, because I can have the possibility to build and test changes without needing to do everything locally. It's a best thing in existence!

No, this is just a small tweak to speed up the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants