fix(devtools): stop DevTools server on flutter shutdown#521
Merged
Conversation
on_flutter_shutdown() only cleared profiler_url and devtools_profiler_url but left devtools_url, devtools_pid, and the DevTools server process alive. After quit and relaunch in debug mode, the stale devtools_url caused the browser to open with the old port instead of the new one. Call M.stop() in on_flutter_shutdown() to kill the DevTools process and clear all state so the next launch starts fresh.
|
if this really all it takes to fix this, could we please merge this in? i've been having this annoyance for a while. would be a nice DX improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_flutter_shutdown() only cleared profiler_url and devtools_profiler_url but left devtools_url, devtools_pid, and the DevTools server process alive. After quit and relaunch in debug mode, the stale devtools_url caused the browser to open with the old port instead of the new one.
Call M.stop() in on_flutter_shutdown() to kill the DevTools process and clear all state so the next launch starts fresh.
fixes #520 (comment)