Repository navigation
fix(config): reject blank root before NVM4313 - #20
Merged
Merged
Conversation
Whitespace-only root is missing input, not an unsafe folder. processRoot must fail with the empty-path message before the install-root deny list so nvm config set matches Validate. Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvm config set root=was classified as NVM4313 becauseprocessRootasked the install-root deny list before the empty-path check.root must be a non-empty pathand skips Put. Unsafe folders still use NVM4313.Test plan
go test ./configin commonTestSet_RunRejectsInvalidRootagainst this common