Repository navigation
Skip index.tab fetch for exact versions - #22
Merged
Merged
Conversation
Air-gapped nvm install of a concrete x.y.z fetched nodejs.org/dist/index.tab before using a local archive. Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
index.tabcatalog fetch when the requested version is already exactx.y.z.Why
Air-gapped
nvm install 24.22.1withlocal_install_onlyfailed on DNS to nodejs.org before the local archive was considered. Exact versions do not need the catalog.Testing
TestFindExactVersionSkipsCatalog(24.22.1,v24.22.1, prerelease prefix)Risk
Low. Partial specs and
lts/lateststill use the catalog. Invalid exact versions fail at download/extract instead of catalog miss.