Skip to content

Constraint orderby type in blocks service #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glyh wants to merge 3 commits into
base: main
Choose a base branch
from
+0 −0
Open

Constraint orderby type in blocks service #131

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
480f45b
Constraint orderby type in blocks service
glyh Oct 28, 2025
22cfb5c
Merge branch 'main' into lyh/blocks/constrain-orderby-type
dkijania Apr 4, 2026
674270b
Revert canonical default and orderBy type annotation
dkijania Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/blocks-service/blocks-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class BlocksService implements IBlocksService {
const dateTimeGte = query?.dateTime_gte;
const dateTimeLt = query?.dateTime_lt;
const canonical = query?.canonical ?? false;
const orderBy = sortBy === 'BLOCKHEIGHT_DESC' ? 'DESC' : 'ASC';
const orderBy: 'ASC' | 'DESC' = sortBy === 'BLOCKHEIGHT_DESC' ? 'DESC' : 'ASC';
const limitValue = Math.min(limit ?? 200, BLOCK_RANGE_SIZE);

// Build the SQL query for blocks with transactions
Expand Down