solidity: Simulated upgrade attack fix - #228
Open
matevz wants to merge 3 commits into
Open
Conversation
matevz
force-pushed
the
matevz/feature/simulation-attack-fix
branch
from
July 30, 2026 14:18
1c3354c to
baa0487
Compare
matevz
force-pushed
the
matevz/feature/simulation-attack-fix
branch
2 times, most recently
from
July 31, 2026 09:20
c1e31aa to
02e1ad7
Compare
matevz
force-pushed
the
matevz/feature/simulation-attack-fix
branch
from
July 31, 2026 09:28
02e1ad7 to
6d69f84
Compare
matevz
changed the title
|
|
||
| console.log(`Deployed new proposed implementation: ${newImplAddress}`); | ||
| } | ||
| const deployTx = await hre.upgrades.prepareUpgrade(args.address, Accounting, { |
Contributor
There was a problem hiding this comment.
existing proxies report VERSION == 1, and this PR leaves the available version at 1, so the check above returns before this migration runs.
| if (args.outputSafe) { | ||
| const data = Accounting.interface.encodeFunctionData("upgradeToAndCall", [newImplAddress, "0x"]); | ||
| if (!args.outputSafe) { | ||
| const txProposeUpgrade = await (await current.proposeUpgrade(newImplAddress, 0)).wait(); |
Contributor
There was a problem hiding this comment.
existing proxies do not implement proposeUpgrade, so the first migration reverts before UPUPS is installed? I suggest adding a legacy one-step bootstrap path and a test that starts from the master implementation. similarly below at 294.
uniyalabhishek
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #198 (Option 4):
UPUPSUpgradeablecontract that enforces a two-step upgradeTested on Sapphire Testnet with Safe: