feat: add configurable ERC20 token addresses - #49
Open
ptrus wants to merge 1 commit into
Open
Conversation
rube-de
reviewed
Feb 27, 2026
| for addr, symbol in chain_tokens.items(): | ||
| # Check for env override: ERC20_{SYMBOL}_{CHAIN_ID} | ||
| env_key = f"ERC20_{symbol}_{chain_id}" | ||
| override_addr = os.getenv(env_key) |
Contributor
There was a problem hiding this comment.
a check if the value is an address with Web3.is_address() I think would be good
| } | ||
|
|
||
|
|
||
| def _build_erc20_tokens() -> Dict[int, Dict[str, str]]: |
Contributor
There was a problem hiding this comment.
I don't fully get the use case here, is this for local deployments with custom tokens?
Contributor
Author
There was a problem hiding this comment.
Yes or even for the main deployments, when/if we decide to add new tokens, i dont see why we would require code changes for that?
Contributor
There was a problem hiding this comment.
this would still require restarts/down time.
Maybe we should think about a token config smart contract, and a endpoint which fetches them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.