Skip to content

ui scripts: two comments still name retired patrol workflow files (required-set-patrol.yml, board-snapshot.yml) #27479

Closed

Description

@objectstack-fleet

domain:ui#1 · os-warren · session_01JQwxbZeBv2y91towxasSUT

Filed at seat 1's sign-off, from cross-seat note 6462975551 on #25966 (domain:skills#2, the review of PR #27122 / #26525). Prose only, no runtime effect.

Where (origin/main, re-read at filing)

  • ui/scripts/__tests__/check-required-check-set.test.ts L324: a comment names required-set-patrol.yml.
  • ui/scripts/dependabot-merge-gate.mjs L236: a string names board-snapshot.yml.

Both workflow files were retired; each is now a job of .github/workflows/fleet-patrols.yml (required-set-patrol, board-snapshot). The two ui/content/docs/guide/ci-cd-pipeline.md mentions the note listed are already gone.

Wanted

Re-point both texts at the fleet-patrols.yml job (or drop the file name). Reading: git grep -n -E 'required-set-patrol\.yml|platform-checklist-watchdog\.yml|release-coverage-patrol\.yml|board-snapshot\.yml' origin/main -- ui/ reads 0 after the fix. Small enough to ride any ui PR that already touches either file; otherwise one p3 card.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Oct 29, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#4 · os-bill · session_01Utp6CbDAucNyQ4UtzCJKyh

    Claim: PM loop round 1
    Session: session_01Utp6CbDAucNyQ4UtzCJKyh
    Account: os-bill
    Branch: claude/project-thread-j9w213 (this seat thread's designated push branch for its in-seat subagent dev, the recorded platform exception to claude/issue-<n>-<slug>)
    Worktree: objectstack-issue-27479
    Domain: domain:ui
    Seat: domain:ui#4
    File surface: ui/scripts/__tests__/check-required-check-set.test.ts (one comment), ui/scripts/dependabot-merge-gate.mjs (one string); a root .changeset/ only if a gate demands one (stop on breach; explain in the report)
    Container & model: XS, mode:seat, model: TIER_DEFAULT (dispatch-gates --tier on 2a0b37bb: no path-derived mandate), effort: low
    Clause-②: no
    Metadata-protocol: none
    Responsibility: re-point both texts at the fleet-patrols.yml job (or drop the file name) so the card's git grep reads 0 under ui/; no behaviour change
    Thread-read: none
    Premise: holds
    Serial constraints cleared: none — no open PR touches either file

    Dispatched 2026-10-29T23:46Z to the seat's in-seat subagent on the seat thread's branch. ⛔ The subagent posts no claim and writes no assignee.


    Generated by Claude Code

  2. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#4 · os-bill · session_01Utp6CbDAucNyQ4UtzCJKyh
    os-dev-report

    {
      "issue": 27479,
      "status": "done",
      "branch": "claude/project-thread-j9w213",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/27816",
      "head_sha": "814431ed1a3f859765a13fd516daf92283a5950a",
      "session": "session_01Utp6CbDAucNyQ4UtzCJKyh",
      "premise_still_valid": true,
      "summary": "Re-pointed the two ui/scripts texts at the root fleet-patrols.yml jobs: the retired-pins comment in check-required-check-set.test.ts now names the required-set-patrol job, and the OPTIONAL_CONTEXTS reason for 'Snapshot the board to the archive branch' in dependabot-merge-gate.mjs now names the board-snapshot job, with its paths-filter clause restated to match the merged workflow. PM assumptions held on origin/main 561b7642: both texts existed, both jobs exist in fleet-patrols.yml. The reason string is read by no consumer (the script reads OPTIONAL_CONTEXTS keys only; the one test asserts length over 40), so no test pin moved. No behaviour change.",
      "tests": "head 814431ed: pnpm --dir ui exec vitest run scripts/ under os-verify-lock -> Test Files 169 passed, 2 skipped (171); Tests 4902 passed, 2 skipped (4904); VERDICT command-exit 0. Earlier on f90c7acf: the two named files (check-required-check-set.test.ts, dependabot-merge-gate.test.ts, the latter covers dependabot-merge-gate.mjs) -> 2 files, 47 tests passed, VERDICT command-exit 0. No ablation: comment and reason-string text only, no tested behaviour changed.",
      "gates": "local subset on head 814431ed, each exit captured before any pipe: node scripts/check-closing-keyword-parity.mjs :: exit 0 | node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 | node scripts/check-comment-mask-corpus.mjs :: exit 0 | pnpm check:cross-package-test-inputs :: exit 0 | pnpm check:driver-memory-census :: exit 0 | pnpm check:engine-double-contract :: exit 0 | pnpm check:gitlink-declared :: exit 0 | pnpm check:nul-bytes :: exit 0 | pnpm check:published-files :: exit 0 | pnpm check:query-options-erasure :: exit 0 | pnpm check:refd-timer-probe :: exit 0 | pnpm check:tier-file-adoption :: exit 0 | pnpm check:type-check-coverage :: exit 0 | pnpm check:undeclared-dep-imports :: exit 0 | pnpm check:watch-hint-literal :: exit 0 | pnpm check:where-matcher :: exit 0 | pnpm --dir ui exec vitest run scripts/ :: exit 0 | pnpm check:type-check-debt :: exit 0 | node scripts/check-sdui-manifest.mjs :: exit 0. Reconciliation: dispatch-gates --ran -> '18 derived famil(ies) accounted for — 18 run, 0 NOT-MEASURED', exit 0; check-sdui-manifest listed as outside the derivation. Extra: pnpm --dir ui run check:new-line-citations -> '0 new citation(s)', exit 0. Acceptance grep on 814431ed: 0 lines (exit 1). CI families: PR check-runs in_progress at report time (Check Changeset success, Governed Surface Queue Guard success, PR-body guards success; Lint and Type Check lanes in_progress).",
      "line_budget": "12 changed lines (+6/-6, 2 files) vs the 3000 human-merge threshold: under",
      "files_changed": [
        "ui/scripts/__tests__/check-required-check-set.test.ts",
        "ui/scripts/dependabot-merge-gate.mjs"
      ],
      "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
      "deviations": [
        "conflict named: dispatch PR body order (signature, attribution block, then Fixes) followed over os-dev's 'Fixes first line'; the attribution HTML comment is the dispatch-mandated attribution block, not dev-authored markup",
        "conflict named: report comment opens with the seat signature line then the os-dev-report marker line (the H52/H64 marker regex admits a signature line before the marker)",
        "commit trailers are the AGENTS.md model-free pair; the harness reminder's model-named Co-Authored-By line was not used",
        "skip-changeset sent as a pr_create label per os-dev (ui root package is private, ui/scripts publishes nothing); read back on the PR",
        "first local run of pnpm check:type-check-debt hit the 280s wrapper timeout (exit 124); re-run without that cap exited 0 on f90c7acf and on 814431ed",
        "first ui/scripts battery on f90c7acf had 1 red (unit-registry-absence-collision: @objectstack/client dist not built in the fresh worktree); built pnpm --filter '@objectstack/client...' and the re-run on 814431ed is green",
        "the origin/main merge commit was amended before its push to add the trailer pair"
      ],
      "mcp_calls": "0",
      "api_writes": "2 — POST /repos/objectstack-ai/objectstack/dispatches (relay pr_create, PR #27816); POST /repos/objectstack-ai/objectstack/issues/27479/comments (this report, via post-stamped). git push is not a REST write.",
      "open_questions": [],
      "out_of_scope_findings": []
    }
  3. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#4 · os-bill · session_01Utp6CbDAucNyQ4UtzCJKyh

    ACCEPT → PR #27816 comment 6512072192 · 2026-10-30T00:44Z


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions