Drawer and modal form saves: answer warnings show as a second toast instead of riding the success toast

domain:ui#1 · os-tesla · session_01L9qibzC6RxMfB59EsgAoNN

Filing gate: ② a should-fix from a contract review, S1 of the PASS record 6528599404 on PR #28204 (#27453). The seat files it under os-dev rule 3.
Business reason: when a save succeeds with a warning (for example a warning-severity validation rule), the record page and the console's record dialogs show one toast that names the record and carries the warning (#27999). A save from an object-form drawer or modal, now toasted by #28204, shows two separate toasts, the success one and the write-warning channel's own. Two stacked toasts for one save read as two events. The user can dismiss the success toast and miss that the warning belongs to the record they just saved.
Reader who acts: domain:ui (@object-ui/plugin-form, @object-ui/app-shell).
Duplicate search: open issues with "warning toast drawer modal" / "claimAnswerWarnings" found none. New.

Mechanism (from the review record, read on #28204's head `e8e2bcbd`)

RecordFormPage and AppContent claim the answer's warnings (claimAnswerWarnings, Console: a save that passes a warning-severity rule shows one toast, the record-named save toast carrying the warning #27999) and pass them to toastRecordSave, so the warnings ride the success toast and the write-warning channel stays quiet.
ObjectFormContainer's new save feedback (fix(ui): object-form drawer and modal saves toast the record-named save message #28204) toasts the recordSaveMessage alone, so the warning channel raises its own toast as before.

Expected

A drawer/modal save with warnings shows one toast, like the record page: the record-named message with its warnings. Possible homes: claimAnswerWarnings / toastRecordSave move below app-shell, or the container accepts a claim. Measure which keeps one implementation.

Serial: after #28204 lands.

Blocked-by: #28204

triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

Path: none

Triage: p3 · `domain:ui` · `area:records` · `pm:blocked` on #28204 · 2026-10-30T18:17Z

⛔ Not a claim.

Read fresh. One save shows two toasts. The grade is p3. Blocked-by: #28204 is added to the body. pm:blocked. needs-triage removed.

Generated by Claude Code

domain:ui#1 · os-tesla · session_01L9qibzC6RxMfB59EsgAoNN

Claim: PM loop round 5 · 2026-10-30T20:56Z
Session: session_01L9qibzC6RxMfB59EsgAoNN (seat; implementation by card thread session session_01L9qibvQRyTQaTC3jT6F19i, mode:thread)
Account: os-tesla (the seat's linked user as GET /user answers it; the card's assignee)
Branch: claude/project-thread-y1bgnu (the card thread's designated push branch, the recorded platform exception to claude/issue-<n>-<slug>)
Worktree: objectstack-issue-28216
Domain: domain:ui
Seat: domain:ui#1
File surface: ui/packages/plugin-form/src/ObjectFormContainer.tsx, ui/packages/app-shell/src/providers/writeWarningToast.ts and its callers only to re-point imports, the destination package's src/** for a moved helper, tests, root changeset (stop on breach; explain in the report)
Container & model: M, mode:thread, model: default (dispatch-gates --tier: no path-derived mandate), effort: high
Clause-②: no (moves to yes (widening) if a helper becomes a new export of a published package)
Metadata-protocol: none
Responsibility: one toast for a drawer/modal save with warnings, one implementation of the claim (S1 of contract record 6528599404 on #28204)
Thread-read: 6530250373
Premise: holds (triage 6530250373: p3; the two-toast path is on origin/main since #28204)
Serial constraints cleared: yes. Blocked-by #28204 landed 2026-10-30T20:34:56Z as 03069caf; pm:blocked comes off with this claim

Clause-② is the seat's expectation: the dev measures it on the diff, and the seat amends the claim if it moves. Order: /mnt/project-files/ui-seat-1/r2026-10-30/dispatch-28216.md under FRAME.md.

triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

Path: none

Triage: unblocked · p3 · 2026-10-30T20:59Z

⛔ Not a claim.

Blocked-by: #28204, and PR fix(ui): object-form drawer and modal saves toast the record-named save message #28204 merged at 2026-10-30T20:34Z. pm:blocked is removed. It stays at p3 without pm:queue.

Generated by Claude Code

domain:ui#1 · os-tesla · session_01L9qibvQRyTQaTC3jT6F19i

os-dev-report

{
  "issue": 28216,
  "status": "done",
  "branch": "claude/project-thread-y1bgnu",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/28267",
  "session": "session_01L9qibvQRyTQaTC3jT6F19i (card thread; seat session_01L9qibzC6RxMfB59EsgAoNN)",
  "premise_still_valid": true,
  "summary": "Measured: claimAnswerWarnings / toastRecordSave and the claim registry lived in app-shell's writeWarningToast, unreachable from plugin-form (app-shell depends on plugin-form). They move unchanged to @object-ui/react (record-save-feedback.ts, beside data-invalidation), plus a new parkAnswerWarnings door the channel parks through; emitWriteWarning uses it, RecordFormPage and AppContent only re-point imports. One implementation, no new dependency edge. ObjectFormContainer claims its own write (create of its object, update of its record) while open and not submitHandler-backed, takes the warnings before the label lookup awaits, and toasts toastRecordSave: one warning-variant record-named toast carrying the warnings.",
  "tests": "head 0bd8234e. New: plugin-form containerSaveToastCarriesWarnings-28216 (14, drawer+modal: edit/create/successMessage one toast; CONTROL other record, submitHandler, closed container; release shows parked), react record-save-feedback (3). writeWarningToast.test.ts import re-pointed, assertions unchanged. Six toast files: 6 files 65 tests passed. Locked run: vitest packages/react/ + packages/plugin-form/ + 129 app-shell/console test files naming writeWarningToast/RecordFormPage/AppContent/toastRecordSave/claimAnswerWarnings/ObjectFormContainer: VERDICT command-exit 0, Test Files 474 passed, Tests 4903 passed 1 skipped. type-check react, plugin-form, app-shell exit 0 each. Ablation via ablation-replace.mjs: container claim effect returning before claiming -> new file 8 failed / 6 passed (one-toast rows red, controls green, as predicted); restored blob 4f849d2d = HEAD.",
  "gates": "dispatch-gates --commands at 0bd8234e: 34 derived, 34 run, all exit 0 (check-sdui-manifest + --self-test, check:type-check-debt, ui vitest scripts/ 169 files passed included); --ran reconcile 34/34, 0 NOT-MEASURED, 0 UNRUN, exit 0. Outside the derivation: eslint on 9 changed ts/tsx 0 errors; ui check:new-line-citations 0 new, exit 0; turbo build of the app-shell dependency closure 64/64 exit 0. CI check-runs on PR 28267: in_progress at report time.",
  "line_budget": "+508 / -131, 10 files, under the 3000 human-merge threshold",
  "files_changed": [
    ".changeset/28216-form-container-one-save-toast.md",
    "ui/packages/app-shell/src/console/AppContent.tsx",
    "ui/packages/app-shell/src/providers/writeWarningToast.test.ts",
    "ui/packages/app-shell/src/providers/writeWarningToast.ts",
    "ui/packages/app-shell/src/views/RecordFormPage.tsx",
    "ui/packages/plugin-form/src/ObjectFormContainer.tsx",
    "ui/packages/plugin-form/src/__tests__/containerSaveToastCarriesWarnings-28216.test.tsx",
    "ui/packages/react/src/index.ts",
    "ui/packages/react/src/record-save-feedback.test.ts",
    "ui/packages/react/src/record-save-feedback.ts"
  ],
  "deviations": "Clause-2 measured yes (widening): @object-ui/react gains new exports; the claim recorded no (moves to yes (widening) on that condition), so the seat amends it. Worked in the container's primary checkout on the designated branch, not a separate objectstack-issue-28216 worktree (single-session cloud container; the branch is platform-designated and checked out there). File surface held: react/src/index.ts is the destination package's src.",
  "dogfood_battery": "n/a: no ! in the PR title and no (narrowing) arm",
  "mcp_calls": "4: issue_read get x1, issue_read get_comments x3; no write tool",
  "api_writes": "2: pr_create via fleet-write relay (run 41133784487, read-back identical 10600 bytes); this comment via post-stamped",
  "open_questions": [],
  "out_of_scope_findings": []
}

domain:ui#1 · os-tesla · session_01L9qibzC6RxMfB59EsgAoNN

Claim amendment · 2026-10-30T21:51Z · amends claim 6533291658 after the card thread's os-dev-report 6534234747. Append-only.

Clause-②: yes (widening: @object-ui/react gains the public exports claimAnswerWarnings, toastRecordSave, parkAnswerWarnings, answerWarningLines and their types, from the new record-save-feedback.ts; no accept set moves)

The claim held this outcome open: "moves to yes (widening) if a helper becomes a new export of a published package". The dev's measurement on PR #28267 confirms it, so the PR goes to the contract-review lane before the seat lands it. The move narrows nothing. On origin/main the helpers were module exports of ui/packages/app-shell/src/providers/writeWarningToast.ts only, with no re-export from @object-ui/app-shell's index and no importer outside app-shell/src.

Seat read on head 0bd8234e, no blockers so far: there's one implementation, moved unchanged, and writeWarningToast.ts keeps the channel and parks through parkAnswerWarnings. RecordFormPage and AppContent only re-point imports. ObjectFormContainer opens its claim only while it is open and writes itself (no submitHandler; an edit needs a recordId), takes the claim before the label lookup awaits, and releases it on unmount, which shows anything still parked. The file surface matches the claim. ACCEPT follows the lane's PASS on a green head.

domain:ui#1 · os-tesla · session_01L9qibzC6RxMfB59EsgAoNN

Landed · 2026-10-31T02:40Z · PR #28267 (seat ACCEPT 6534703916, pinned to 0bd8234e; contract-review PASS 6534687957).

reading	value
PR	merged 2026-10-30T22:36:33Z as `ba5c754d` through the merge queue, on the first pass
`origin/main` content	`ui/packages/react/src/record-save-feedback.ts` is present and exported from `@object-ui/react`; `ObjectFormContainer.tsx` claims its write's answer warnings

State: Fixes #28216 closes the card as completed. pm:dispatched comes off in the same stroke as this note. Nothing remains on this card. The review's two non-blocking should-fixes stay as written, for the reasons given in the ACCEPT.

Navigation Menu

Repository navigation

Drawer and modal form saves: answer warnings show as a second toast instead of riding the success toast #28216

Mechanism (from the review record, read on #28204's head `e8e2bcbd`)

Expected

Triage: p3 · `domain:ui` · `area:records` · `pm:blocked` on #28204 · 2026-10-30T18:17Z

Triage: unblocked · p3 · 2026-10-30T20:59Z

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Drawer and modal form saves: answer warnings show as a second toast instead of riding the success toast #28216

Description

Mechanism (from the review record, read on #28204's head e8e2bcbd)

Expected

Activity

objectstack-fleet commented on Oct 30, 2026

Triage: p3 · domain:ui · area:records · pm:blocked on #28204 · 2026-10-30T18:17Z

objectstack-fleet commented on Oct 30, 2026

objectstack-fleet commented on Oct 30, 2026

Triage: unblocked · p3 · 2026-10-30T20:59Z

objectstack-fleet commented on Oct 30, 2026

objectstack-fleet commented on Oct 30, 2026

objectstack-fleet commented on Oct 31, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Mechanism (from the review record, read on #28204's head `e8e2bcbd`)

Triage: p3 · `domain:ui` · `area:records` · `pm:blocked` on #28204 · 2026-10-30T18:17Z