Repository navigation
test(ui): run the kept Console live specs nightly; delete the stale and duplicated ones - #27294
Merged
Merged
Conversation
…hat are stale or duplicated The live specs outside the required Live E2E UI job ran in no CI lane. Each of the eighteen was run on the workspace backend: fifteen pass and are kept, listed once in ui/package.json's test:e2e:live:nightly and run by examples/app-showcase/test/console-live-specs.live.test.ts in the nightly live tier. Deleted: studio-record-page (a record page is now created slotted with no copied regions, by design), detail-related-list (a row's name link now opens the record drawer, by design) and showcase-smoke (every surface and assertion it held is in the showcase package's nightly smoke). Claude-Session: https://claude.ai/code/session_01JQwxbXq8B9svQTRonMmTRf Co-authored-by: Claude <noreply@anthropic.com>
…MSW error excuse The platform checklist cited studio-record-page.spec.ts, detail-related-list.spec.ts and the ui/e2e/live showcase smoke, which this branch deletes. Each citing line is repointed (showcase smoke -> examples/app-showcase/e2e/showcase-smoke.spec.ts) or dropped, with a revision bump and history entry per item. console-rendering.spec.ts no longer excuses mockServiceWorker/MSW console errors: the Console ships no mock service worker, and the idle MSW test was already removed. Claude-Session: https://claude.ai/code/session_01JQwxbXq8B9svQTRonMmTRf Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
domain:ui#1 · os-warren · session_01JQwxbZeBv2y91towxasSUT 席位核对ACCEPT · seat 席位意见:执行裁决 Q3 B。18 个在任何 CI 都不跑的 live e2e spec 逐个在工作区后端实跑:15 个绿的保留,由 Nightly Tiers 的 showcase 分片每晚跑(红了会自动立卡并点名 spec);3 个删除(2 个已过时、1 个与 showcase 自带的夜间冒烟重复)。空转的 MSW 测试早已不在,这里清掉了残留的 MSW 忽略项。不是 Tier H。
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Warren · project thread
Fixes #25914
Clause-②: no
Metadata-protocol: none
维护者速读
ui/package.json一行脚本),删掉 2 个过时的红 spec 和 1 个与 showcase 夜间 smoke 重复的 spec,并改正引用它们的检查单条目。Live E2E UIjob;夜间 showcase 分片多约 5 分钟;回滚即 revert 本 PR。examples/app-showcase/test/console-live-specs.live.test.ts,以及下面的逐 spec 表。pnpm --dir ui run test:e2e:live:nightly --list,预期列出 15 个文件、25 个用例。What changes
Each of the 18 live specs outside
test:e2e:live:ciwas run alone against the workspace showcase backend (ui/e2e/live/ci/start-backend.sh, the boot the required job uses) atorigin/main1e8e5296. Both reds were run a second time and failed the same way.cascading-optionsdeclared-sharing-rules-reach-13091detail-related-listwaitForURL(/record/)timeoutfield-conditional-rulesform-view-subformsgrid-conditional-rulesgrid-file-uploadgrid-parent-rulesinline-edit-polish-2572list-row-action-celrecord-history-displayrequired-when-submitshowcase-smokestudio-editorstudio-object-designerstudio-record-pageblocks.length0summary-rollupuser-filtersWiring (route A, amendment 6470826683), not Tier H.
ui/package.jsongains one script,test:e2e:live:nightly, that lists the 15 kept specs.examples/app-showcase/test/console-live-specs.live.test.tsis a*.live.test.tsfile, so Nightly Tiers already selects it in the showcase shard, which builds the Console and installs Chromium. Its report step files a card on red.showcase-smoke.live.test.ts:start-backend.sh.VITE_BASE_PATH=/into a scratch dir and serves it withvite previewplusDEV_PROXY_TARGET. The specsgotoroot/apps/..., which neither the default./base nor the/_consolecopy serves.finally..github/workflows/**edit, andci.ymlandui/.github/**are untouched.showcase-smokeis a duplicate.examples/app-showcase/e2e/showcase-smoke.spec.tsalready runs nightly throughshowcase-smoke.live.test.ts.comm -23of the two path lists is empty; one label changed from "Settings (preference)" to "Settings" on the same path).studio-record-pageis stale. It expects a record page created in Studio to come back with regions copied from the default layout. Today a new record page is created slotted with no copied regions, by design, soblocks.lengthis 0.detail-related-listis stale. It expects a row click to navigate to/record/. Today the row's name link opens the record drawer, by design. The related-list behaviours it also touched are pinned by unit tests:deriveRelatedLists.test.ts,buildDefaultPageSchema.test.tsandRelatedList.columnIdentityAccessor.test.tsx.The MSW clause. The vacuous MSW test in
ui/e2e/console-rendering.spec.tswas already deleted by test(ui-e2e): delete the vacuous MSW worker test and the unused msw declarations #26032, so that part of the premise no longer holds. What was left was four ignore entries (mockServiceWorker,MSW,Mock Service Worker,[MSW]) that still excused MSW console errors. They are removed: the Console ships no mock service worker, so an MSW error is now a real error. Nomswdeclaration and nopublic/mockServiceWorker.jsare left in the tree.Platform checklist. Every line that cited a deleted spec was repointed or dropped. Each item gets a revision bump and a
historyentry dated 2026-10-28, with ref e2e: the MSW test in console-rendering.spec passes when the worker is absent (it is absent), and 18 of 22 live specs run nowhere in CI — delete the vacuous test and make the four live specs count #25914.platform-core.metadata-authoring-roundtripplatform-core.metadata-authoring-roundtriprecords-forms.related-list-server-paginationrecords-forms.related-list-server-paginationrecords-forms.related-list-server-paginationrecords-forms.related-list-server-paginationstudio-authoring.record-page-roundtripstudio-authoring.record-page-roundtripstudio-editor, now nightly, which covers none of acceptance[0], [2] or [3]studio-authoring.record-page-roundtripstudio-authoring.custom-page-render-and-blocksexamples/app-showcase/e2e/showcase-smoke.spec.ts; that nightly smoke includes the pages namedstudio-authoring.page-variables-and-actionsstudio-authoring.custom-page-source-tiersOut of scope, flagged for the ledger owner.
platform-coreacceptance[2] andstudio-authoring.record-page-roundtripacceptance[0] still ask for regions "seeded from the default layout". That now holds only forfullpages. The two history entries say so; the acceptance text is left as it is.Why
Ruling Q3 B (6435339772): the stale specs are deleted and the rest are wired into Nightly Tiers, so a red files a card. The other clauses of the card are already closed:
This PR closes the last one, hence
Fixes.Verification
The 18-spec measurement held the verify lock for 4m45s with
VERDICT command-exit 0. The per-spec results are in the table above.The wrapper ran end to end:
OS_TEST_TIERS=nightly pnpm --filter @objectstack/example-showcase exec vitest run test/console-live-specs.live.test.tsgave Playwright 25 passed (1.7 min) and vitest 1 passed. It held the lock for 4m27s with VERDICT 0.ui/e2e/console-rendering.spec.tsran in Chromium against a/console/build: 3 passed.node scripts/pm/dispatch-gates.mjs --commandsderived 55 commands at the merge oforigin/main0d45c0e7. To those I added:pnpm --filter @objectstack/example-showcase typechecknode scripts/nightly-tiers.mjs --checknode scripts/check-platform-checklist.mjs --changed-from origin/mainAll 58 exited 0.
dispatch-gates --ran: "55 derived famil(ies) accounted for — 55 run, 0 NOT-MEASURED".check:dts-closureandcheck:dual-build-cjs-loadsexited 1 and 3 on the first pass for the same reason. Both read built output this worktree had not built: consoleplugin.d.ts, and thedistof 7 packages this diff does not touch. Each exited 0 after the build of those packages (build:pluginfor the console, thenturbo run build).dispatch-gates --tier: "no path-derived mandate: the surface hits none of the 4 declared glob(s)". Changed lines: 514 (+275 / -239), under the 800 cap.This is test and CI only, so it ships no changeset (
skip-changeset).Human Minimum
packages/specholds no runtime logic. (Nopackages/specchange.)pnpm lintpasses. (The root eslint, run over the two changed TypeScript files, exits 0.)main, one pull request.skip-changeset.)packages/spectouched: its generated artifacts are regenerated and committed. (Not touched.)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.维护者速读block the dispatch order asks for.)🤖 Generated with Claude Code
https://claude.ai/code/session_01JQwxbXq8B9svQTRonMmTRf