Skip to content

docs: retire manifest-deps from the plugin-distribution note, re-point two stale plugin-build checklist negatives, correct the liveness manifest cell - #27698

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-27685-manifest-deps-leftovers
Oct 29, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-27685-manifest-deps-leftovers

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #27685

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

Tests

No code changed, so no unit tests were added and none were run. Nothing was ablated, because no tested behaviour moved.

Acceptance notes

  • Item 4 of the card (ui/packages/app-shell/src/console/marketplace/marketplaceApi.ts:171) is untouched, per triage 6504381957. It rides the next domain:ui PR there.
  • Not edited, recorded here, no card (stale prose, no reach): docs/adr/0025-plugin-package-distribution.md still names manifest-deps as live at L159 (the manifest example comment), L267 (§3.5 step 5) and L595–596 (the consequences bullet), while its own §3.3 retires it. The ADR is a governed surface and outside this card.
  • Not edited, outside this card's passages: plugin-distribution.md says the bundle is built with tsup (§4.1 tree, §5 step 1). The build uses esbuild (packages/cli/src/commands/plugin/build.ts; ADR-0025 v2 §3.3 says the same). §4.3 as rewritten names no bundler.
  • Coverage observation, no card: no platform-checklist item scores the install-time integrity refusal or the boot-time tier dispatch. The two re-pointed negatives now name that code as unscored here.

Verification

H3: the count is generated, not hand-kept. pnpm --filter @objectstack/spec gen:liveness-counts exited 0 and rewrote 0 shards, and the committed state-counts/manifest.md already reads dead 13 / planned 1. Only the README prose was stale, so it was corrected from liveness/manifest.json, and no number was typed into the shard.

Gates, derived by node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at 8dee70e6bb (59 commands), every exit code captured before any pipe:

54 exit 0 · 5 NOT MEASURED (exit 3, PREREQUISITE NOT MET) · --ran reconciliation 59/59 accounted
  • --ran verdict: ✓ dispatch-gates --ran: 59 derived famil(ies) accounted for — 54 run, 5 NOT-MEASURED (5 DERIVED from a recorded exit 3).
  • pnpm check:platform-checklist exit 0: check-platform-checklist: OK — 16 areas, 352 items (347 active, 1 planned) (the three new path#symbol source anchors resolve).
  • pnpm --filter @objectstack/spec run check:liveness exit 0: ✓ packages/spec/liveness/state-counts/ is current — one shard per governed type, the same 43 row(s) as the README, no count column left in the README.
  • pnpm check:doc-authoring exit 0 · pnpm check:nul-bytes exit 0 · pnpm check:issue-citations exit 0 · pnpm check:published-files exit 0.
  • node scripts/check-adr-0087-registration.mjs --base origin/main exit 0: this PR adds no declared-breaking changeset · check-changeset-no-major exit 0 · check-empty-changeset exit 0.
  • NOT MEASURED: check:doc-formula-expressions (@objectstack/formula not built), check:dts-closure, check:dual-build-cjs-loads, check:lean-entry-closure (@objectstack/objectql dist absent), check:sourcemap-no-sources-content. Reason: each reads the built dist of packages this diff does not change, and building the workspace for a docs-only diff is the declared narrowing. CI's Lint & Repo Gates runs them on a built tree.
  • Local-only families check:dev-prereqs / check:skill-frame-freshness: not run, because the diff touches neither the packages/spec build nor the four-axis frame files.

Generated by Claude Code

…strategy; manifest-deps retired

Claude-Session: https://claude.ai/code/session_01QSeKYmTYfaPbLQD4BJfomW
Co-authored-by: Claude <noreply@anthropic.com>
…ust-tier negatives; correct the liveness README manifest cell

Claude-Session: https://claude.ai/code/session_01QSeKYmTYfaPbLQD4BJfomW
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️ 1 changed file(s) yielded no anchor (packages/spec/liveness/README.md), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/spec/liveness/README.md) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 167 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json bfdaba4322e1258a7657aa622af021e31ab071aa → packageMentionDocs.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:devx#2 · os-justin · session_01QSeKYmTYfaPbLQD4BJfomW

席位核对 — ACCEPT · domain:devx#2 · head 8dee70e6bb · 2026-10-29T19:45Z

维护者速读

席位意见:合入。每一句都按代码树写,不是照卡片转述。两条否定句没有删掉,而是改成「这一项不计分,校验在别处」,并指向具体代码;计分条款一字未动。README 计数先确认生成分片已是最新(13),再改手写的那句,没有手填数字。

Shape: draft → main, Fixes #27685. 4 files: docs/design/plugin-distribution.md, docs/qa/platform-checklist/areas/cli.json, packages/spec/liveness/README.md (the cross-domain file triage granted in 6504381957), and .changeset/27685-manifest-liveness-cell.md (@objectstack/spec patch, Clause-②: no). +52/−22. Labels documentation, size/s, tooling; no skip-changeset, since a changeset is owed (liveness is in spec's files). No assignees or reviewers (non-governed; the seat lands it). The dev opened it through the relay; report 6506244559, claim 6505583616.

Premise measured: holds after #27679. PluginPackagingSchema is enumWithRetiredValues(['bundled'], PACKAGING_RETIRED), and build.ts has a single esbuild path.

Seat's own read of the diff:

Gates: on head 8dee70e6bb, 50 check-runs: 40 success, 10 skipped, 0 failure; mergeable_state: clean. Spec property liveness, Check Changeset and every Lint · lane are success. check-expected-skips --pr 27698: OK, all 10 skips are in main's roster (exit 0). check-governed-merges --pr 27698: NOT governed, 74 changed lines. Dev's union: 59 derived, 54 run with exit 0, and 5 NOT MEASURED by prerequisite (built-dist readers; this diff changes no package build). CI's lint lanes ran those 5 built and are green.

Accepted deviations:

  • §8 supply-chain bullet edited beyond the claim's line list. It is the same file and the same manifest-deps class, and the PR body declares it.
  • A changeset was added instead of skip-changeset, because the README ships.
  • The PR has no assignee, per the relay's pr_create rule.

Out of scope, with destinations:

Landing: non-governed, 74 changed lines. In this act the seat readies the PR and arms auto-merge. On merge, the seat verifies the merged diff and posts the landing note on #27685. There is no cloud session to archive (mode:subagent).


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 29, 2026 19:46
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 29, 2026 19:46
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 2b4b970 Oct 29, 2026
51 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-27685-manifest-deps-leftovers branch October 29, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s tooling

Projects

None yet

1 participant