[objectstack-fleet]

Requested by Elon · project thread

domain:server#3 · os-elon-musk · session_016WV4cyGcBtnptfcfKE14ZS

Fixes #27839

What changes

In packages/rest/src/import-job-integration.test.ts, the control "a cancel that lands after the last row still wins over an all-failed outcome" now records how many rows the results read returned during its 400 × 5 ms wait, and asserts it reached 3 before it checks the job row. Test-only; no product change.

Why

The worker's final patch is the only write of results. If the wait ran out, the cancel route's own cancelled write and the progress flush could satisfy the status and count checks without the final patch ever landing. The new assertion makes an exhausted wait fail on its own cause (contract review of #27795, record 6512470441, should-fix 1).

Verification

• npx vitest run src/import-job-integration.test.ts in packages/rest: 21/21 pass.
• Ablation (local, restored): with the wait loop cut to 0 iterations, the new line fails with expected +0 to be 3. Under the same ablation the pre-change test also fails, but on the later toMatchObject counts, which does not name the wait.
• packages/rest full suite: 357 files, 7073 passed, 350 skipped.
• dispatch-gates --ran: 49 derived, 47 run green, 2 NOT MEASURED (exit 3, worktree prerequisites: check-plugin-teardown-shape --self-test, check:dual-build-cjs-loads), 0 unrun.
• pnpm lint: exit 0.

Skills-docs: none. grep -rn "late-cancel\|late cancel" skills docs returns nothing; no skill or doc describes this test.

Clause-②: no
Metadata-protocol: none

No changeset: a test file publishes nothing from any released package (skip-changeset).

Human Minimum

• 1. Schemas start as Zod; packages/spec holds no runtime logic. (not touched)
• 2. Every name I added uses the casing for its kind.
• 3. No formatter ran; pnpm lint passes.
• 4. One issue, one branch off an up-to-date main, one pull request.
• 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset. (publishes nothing)
• 6. packages/spec touched: its generated artifacts are regenerated and committed. (not touched)
• 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
• 8. Title, body and comments are in English.
• The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_016WV4cyGcBtnptfcfKE14ZS

[github-actions]

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see

• a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
• a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 847e4248e9b7059e5b069056bf636c75c1f53b14 → packageMentionDocs.

[objectstack-fleet]

domain:server#3 · os-elon-musk · session_016WV4czuTWNgKR22fKv7jia

Seat ACCEPT · PR #28067 · head 857c016592d89e360859435e0e272e87989a5852 · 2026-10-30T11:51Z

维护者速读

• 改了什么： 只改测试。异步导入「晚取消」那条用例原先等 worker 写回 3 行结果，等不到也照样往下跑；现在等完必须断言确实拿到 3 行（rest: the async import late-cancel pin should assert its wait for the worker's results write actually completed #27839）。
• 为什么改： 等待耗尽时，取消接口自己的写入和进度刷新就能让后面的断言通过，用例会假绿。
• 风险与回滚： 无产品代码改动；回滚即删这一行断言。
• 先看： packages/rest/src/import-job-integration.test.ts 约 621 行。
• 两分钟验证： 本地把等待次数改成 0，该用例应报 expected +0 to be 3。
• 需要你做的： 无（Tier S，按本期落地授权由席位落地）。

席位核对

• Shape: draft → main, Fixes #27839. One file, packages/rest/src/import-job-integration.test.ts (+6/−1), skip-changeset (test only). check-governed-merges --pr 28067: NOT governed.
• Premise: re-read on main @ 5aee2065: the late-cancel control polled 400 × 5 ms for results.length === 3 and never asserted it.
• Read of the diff: the loop records the last length it read, and expect(reported).toBe(3) follows the wait, before the status and counter assertions. Ablation shown by the thread: wait cut to 0 → expected +0 to be 3; restored 21/21.
• Declarations: test only; no published surface, no contract review owed.
• Gate check-runs on this head: 53 total, 35 success, 18 skipped by the path filter, 0 failed. mergeable_state: clean.
• Landing: Tier S, under the maintainer's landing grant for this term (2026-10-29 22:05Z, seat thread). Ready + auto-merge through the relay.

ACCEPT