[objectstack-fleet]

Requested by Bill · project thread

维护者速读

• 改了什么：Studio 自动化里打开一个可写软件包的流程，页头多了一个 ⋯ 菜单，里面是「删除流程」。点了先弹出控制台内的确认框（和 Setup 一样，写出流程名和 flow/名字），确认后先丢弃这个流程的待发布草稿，再删除流程；左栏重新读取，页面回到空状态，提示「已删除流程「…」」。只读包（代码包、已安装包）的流程不画这个菜单。
• 为什么改：Setup and Studio: suggestions from a full HotCRM browser pass on 18.2.0: user onboarding, packaged automation state, run-now for scheduled flows, admin lists, and Studio entry, field table, flow inspector wording and one designer per item #27356 第 19 行，按你的裁决 A1（评论 6520616687）：Studio 先能删除流程；Reset overlay、启停开关和复制随 ADR-0146 第 2 阶段（docs(adr): ADR-0146 — Studio designs, Setup administers; one editor per metadata item; paired <base>.customize package #28045）再做。
• 风险与回滚：只在可写包的流程上多一个删除入口，走的是 Setup 删除用的同一个 DELETE /meta/flow/:name，带上 Studio 写草稿用的同一个包；服务端拒绝时显示服务端原话，流程保持打开。回滚就是 revert 本 PR。
• 先看：StudioDesignSurface.tsx 里 AutomationsPillar 的 deleteOpenFlow（#27356 row 19 注释处），以及新文件 FlowItemMoreMenu.tsx。
• 两分钟验证：pnpm --dir ui exec vitest run packages/app-shell/src/views/studio-design/AutomationsPillar.deleteFlow-27356.test.tsx，应见 4 passed。
• 需要你做的：无，席位落地。

Part of #27356 (row 19, hotcrm#2320 Studio S8: Studio can delete a flow; maintainer-ruled A1, comment 6520616687)
Clause-②: no
Metadata-protocol: none

What changes

• A ⋯ menu on an open flow. In the Automations pillar, the header of an open flow of a writable package gets a ⋯ button (auto-item-more, aria 「More」, the header's icon-button token) after the Enabled switch. Its one item is 「Delete flow」 (auto-item-delete, Trash icon, destructive colour). It is disabled while a save is in flight, so the delete never races the autosave. Before this, a flow could be deleted only from Setup › Metadata (objectui#12725).
• The confirmation is Setup's. The in-app AlertDialog (objectui#13333; never the browser's confirm()) reuses Setup's own keys, engine.edit.deleteConfirm / engine.edit.deleteConfirmBody / engine.edit.delete, with the same variables Setup's ResourceEditPage passes: the flow's label, flow/NAME and the type's label. Cancel closes it with nothing sent.
• The delete. deleteOpenFlow disarms the autosave (setAutoDirty(false)). When the flow has a pending draft, it first discards it with client.reset('flow', name, { state: 'draft', packageId }), so no draft is left to publish the flow back. It then deletes the flow with client.reset('flow', name, { packageId }), which is DELETE /meta/flow/:name, the door Setup's delete uses. packageId is the package Studio writes the flow's drafts to (objectui#12335's binding).
• After the delete. The pillar clears the open flow, drops it from the rail and re-reads the list (flowListNonce). A one-shot ref keeps that re-read from opening another flow, so the pillar lands on its empty state. onDraftSaved is called so the shell's pending-drafts count re-reads, and a toast names the flow: 「Deleted flow "LABEL"」.
• A refusal. A refused delete (for example 409 RESOURCE_CONFLICT) shows the door's own sentence in the pillar's refusal strip, the same plainRefusal path every other refused write here uses, and the flow stays open.
• A read-only package draws nothing, and neither does a flow that has not finished loading or a pillar with no package binding.
• No Reset overlay. Per the ruling, Reset overlay, the Enabled toggle and Clone on a packaged flow arrive with ADR-0146 Phase 2's overlay editing (docs(adr): ADR-0146 — Studio designs, Setup administers; one editor per metadata item; paired <base>.customize package #28045), not here.
• i18n. Two keys added to the studio namespace (en, zh): engine.studio.auto.deleteFlow (en 「Delete flow」, zh 「删除流程」) and engine.studio.auto.flowDeleted (en 「Deleted flow "{item}"」, zh 「已删除流程「{item}」」). Other locales fall back to en, as the namespace allows. No key renamed, no en value changed.

Tests

• New AutomationsPillar.deleteFlow-27356.test.tsx (4 tests) on the real AutomationsPillar, the server doubled at the metadata client (the harness of AutomationsPillar.showMeFocus-26730). The rail serves two flows, so that opening the second one after the delete would show.
  • With a pending draft: the dialog names "Approval" and flow/approval; nothing is sent before Delete; then the two calls are the draft discard and the delete, in that order, at the package; the list is re-read; "Approval" leaves the rail, "Escalate" stays and is NOT opened (no layered read of it, no canvas caption); the toast names the flow.
  • No pending draft: the one delete call.
  • Refused (409): the refusal strip shows the server's sentence, the flow stays open, no toast.
  • Read-only package: the flow opens and there is no ⋯ menu.

Readings (head c090d58, branch rebuilt from origin/main 6b125a7 after #28076 merged; install and app-shell closure rebuilt)

• New file: 4/4 passed.
• Every ui test file naming StudioDesignSurface, AutomationsPillar or FlowItemMoreMenu (209 files): 209 passed, 1561 passed.
• pnpm --filter @object-ui/app-shell run type-check and pnpm --filter @object-ui/i18n run type-check: exit 0 (lock VERDICT command-exit 0).
• Ablation 1, through scripts/ablation-replace.mjs: the draft discard await client.reset('flow', flow.name, { state: 'draft', packageId }); to /* ABLATED */: 1 failed / 3 passed (the pending-draft case red: one call, not two); restored blob = HEAD blob 95e9a7fd2a3e, git diff HEAD empty.
• Ablation 2: (keepEmpty ? c : (c ?? to (/* ABLATED */ (c ?? (the re-read opens the next flow): 1 failed / 3 passed (the pending-draft case red: "Escalate" opens, so its name shows twice); restored, git diff HEAD empty.
• vitest resolves @object-ui/* to source, so neither ablation needed a rebuild.
• pnpm --dir ui run check:i18n-drift: no en value changed.

Acceptance notes

• The card stays open. After this PR every Studio row of Setup and Studio: suggestions from a full HotCRM browser pass on 18.2.0: user onboarding, packaged automation state, run-now for scheduled flows, admin lists, and Studio entry, field table, flow inspector wording and one designer per item #27356 (12–22) is taken, carded or answered. The Setup rows 1, 4, 5, 6, 7, 8, 10 and 11 have no card or answer yet (seat 2's note 6488880391), so this PR is Part of, not Fixes.
• Draft first, then the flow. Setup's delete sends only the delete. Studio also discards the flow's pending draft first, because Studio's autosave keeps one and a draft left behind could publish the flow back. If the draft discard succeeds and the delete is then refused, the flow stays open without its draft: what was published is unchanged, and the unsaved draft edits are gone. That case is not separately pinned.
• The ⋯ menu holds one item today. Reset overlay, the Enabled toggle and Clone join it with ADR-0146 Phase 2.
• Measured in happy-dom against a doubled metadata client, not a running server: the 409 sentence is the test's, and whether the server refuses a flow other items reference was not measured here.

Verification

On head c090d582: dispatch-gates --commands derived 34 families for this diff; all 34 were run locally, each exit 0, and --ran reconciled 34 run, 0 NOT-MEASURED, 0 UNRUN. check:new-line-citations: 0 new. CI check-runs were in progress when this was opened.

The harness's after-PR assign and review-request step is skipped on the order's word.

---

Generated by Claude Code

[objectstack-fleet]

domain:ui#3 · os-bill · session_01Utp6CaJoinvGQSbHeDaWBe

席位核对

ACCEPT · head ae7dc3db9d021d9276a348f9f3ebac119a900029 · 2026-10-30T13:43Z

• Shape: draft → main, Part of #27356 (row 19). The card stays open: Setup rows 1, 4, 5, 6, 7, 8, 10 and 11 have neither a card nor an answer yet (seat 2's note 6488880391). Clause-②: no and Metadata-protocol: none match the claim. The change is Studio-side only (@object-ui/app-shell, plus studio en/zh keys), so no contract review is owed.
• Ruling held (6520616687, A1): a flow open in a writable package gets a ⋯ menu with "Delete flow". The confirm reuses Setup's (objectui#13333, the engine.edit.deleteConfirm keys). On confirm, the item's pending draft is discarded first, then the flow is deleted through client.reset('flow', name, { packageId }), the same DELETE /meta/flow/:name door Setup uses. Afterwards the rail reloads, the page stays on the empty state (the next flow does not open), and a toast names the flow. A server refusal shows the server's words and keeps the flow open. A read-only package draws no menu. There is no Reset overlay, per the ruling (that is ADR-0146 phase two, [Epic] Studio designs, Setup administers (ADR-0146): one editor per metadata item, in-place customization on read-only packages, the paired <base>.customize package, the metadata catalog moves into Studio #28130).
• Tests: AutomationsPillar.deleteFlow-27356 4/4. Studio neighbours: 209 files, 1561 tests. Two ablations each give 1 red / 3 green, and both were restored. Type-check passes for app-shell and i18n.
• Head note: the PR body's readings are on c090d582. The only later commit, ae7dc3db, re-points a code comment from ADR-0146 to docs(adr): ADR-0146 — Studio designs, Setup administers; one editor per metadata item; paired <base>.customize package #28045 to clear check:adr-anchors: the ADR is still a draft PR and is not under docs/adr/. It changes no logic.
• Gates (check-runs on the head): 44 success, 11 skipped, 0 failure; mergeable_state clean. 34/34 derived gates exit 0 locally. check-governed-merges --pr 28126: NOT governed, 298 changed lines.
• Accepted deviations: discarding the draft before the delete is a step Setup's delete does not take. It is needed here so the draft cannot outlive the flow, and it is recorded in the Acceptance notes.
• Landing: non-governed, all checks green, mergeable_state clean ⇒ the seat lands it (pr_ready + automerge_enable).

---

Generated by Claude Code