test(api): 32 edge-case tests + fix(notifications): add test/verify endpoint for notification channels#224
Open
farrasrayhand wants to merge 12 commits into
Open
test(api): 32 edge-case tests + fix(notifications): add test/verify endpoint for notification channels#224farrasrayhand wants to merge 12 commits into
farrasrayhand wants to merge 12 commits into
Conversation
…nal helpers, webhook SSRF validation
farrasrayhand
changed the title
…ve test dependency issues
…id YAML parse error
…regex doesn't support nested braces
farrasrayhand
changed the title
…r compat) GNU tar does not support --no-absolute-names; it strips absolute paths by default. The pre-extraction assertTarEntriesSafe already validates all entry paths for traversal attacks.
Member
|
i have pr that needs to refactor these test cases, please refactor the tests to match the new webhook design |
…blicWebhookUrl - Replace assertPublicWebhookUrl call with assertPublicUrlLiteral from ssrf-guard - Delete redundant webhook-url.ts and its test - Add 22 ssrf-guard tests covering isPrivateIp, isBlockedHostname, assertPublicHostLiteral, assertPublicUrlLiteral
…eFetch already handles SSRF internally
Contributor
Author
Done! Refactored to use the existing
Let me know if you need any adjustments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #193 (merged). Adds edge-case tests to help stabilize the codebase.
Refs #216, Refs #148
Tests Added (27 tests)
1.
compose-parser.test.ts— 5 tests${VAR:?error}/${VAR?error}operators: unset, empty, happy path2.
terminal-helpers.test.ts— 12 tests (new file)safeWsSend,safeWsClose,safeShellWrite,safeShellClose3.
ssrf-guard.test.ts— 10 tests (new file)ssrf-guard.ts:isPrivateIp,isBlockedHostname,assertPublicHostLiteral,assertPublicUrlLiteralRefactor
assertPublicWebhookUrlin notification-workers with the codebase-standardassertPublicUrlLiteralfromssrf-guard.tsRunning