Dashboard: fix typecheck error in AddCustomAppModal#236
Open
ahmedhesham6 wants to merge 1 commit into
Open
Conversation
`template` is `useState<unknown>`, so `{template && …}` types the
short-circuit value as unknown, which is not assignable to ReactNode.
Compare against null instead so the expression narrows to boolean.
Broke on main in e8bc360 and fails every CI run since (e.g. the oblien#235
merge run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's Typecheck job fails on
main(and therefore on every PR, including #222):templateisuseState<unknown>, so{template && …}can evaluate to theunknownvalue itself when it's falsy, and JSX rejectsunknownas a child. Comparing againstnullnarrows the guard to a boolean.Introduced on
mainin e8bc360; the #235 merge run shows the same failure, so this is not specific to any open PR.One-line change, no behavior difference (
templateis only evernullor a parsed object).