Repository navigation
Conversation
…ccept Assisted-By: Claude Opus 5.5
…ccept Assisted-By: Claude Opus 5.5
|
A couple things that Claude flagged:
|
Caleb-Hurshman
requested changes
Oct 30, 2026
Caleb-Hurshman
left a comment
There was a problem hiding this comment.
Pretty cool, see my comment above for stuff that needs tweaking
Assisted-By: Claude Opus 5.5
…es up a seeded filegen pick Assisted-By: Claude Opus 5.5
Contributor
Author
|
The byte-for-byte limit is documented in filegen.md. Replay's retry cap is in #345, which drops a line after three failed retries. A run whose destination keeps rejecting one hostmetrics scraper still waits, since the count is of delivered records. That rejection now logs at error, so the stall shows up. The seed docs now say a failed send uses up a pick, so delivered lines only repeat when every send succeeds. |
Caleb-Hurshman
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Add deterministic replay mode in addition to the normal random read mode. In this mode (
generator.filegen.mode: replay), Blitz sends every line of a capture file once, in order, then ends the run. Lines without timestamp directives replay byte for byte. There is also a newgenerator.filegen.seedthat makes random-mode line picks repeatable.count.Tracker.Acquirenow returns aPermitthat the generator settles withCommitorRelease. Embedders callingcount.Trackerdirectly need the new API.Checklist