Skip to content

add mvp#1

Merged
jashan-lco merged 12 commits intomainfrom
mvp
Feb 1, 2022
Merged

add mvp#1
jashan-lco merged 12 commits intomainfrom
mvp

Conversation

@jashan-lco
Copy link
Copy Markdown
Collaborator

No description provided.

@jashan-lco
Copy link
Copy Markdown
Collaborator Author

Keeping this repo private until this is integrated into https://github.com/observatorycontrolsystem/ocs_example

I've tested this using ocs_example. I had to use libfaketime to mock the system time, so that it would actually run through the observations. Otherwise they were days out. For example:

$ poetry run faketime '2022-01-26T05:01:50+00:00' virtual-site --name ogg --api-url http://localhost:8000/api/ --api-token 'sutoken1234abcdl'

Just change the datetime to just before the first observation.

@jashan-lco
Copy link
Copy Markdown
Collaborator Author

observatorycontrolsystem/ocs_example#11 integrates this into ocs_example

Copy link
Copy Markdown

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! A few comments.

I also think perhaps some docstrings and/or inline comments could increase clarity inside of virtual_site.py. I like the logging that's there, but since it's a demonstrative piece of code, it'd be nice to have it annotated just a little bit.

Comment thread .github/workflows/publish-docker.yaml Outdated
Comment thread .github/workflows/publish-docker.yaml
Copy link
Copy Markdown
Member

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree with Matt that more inline comments, and README description would be nice just since it's meant to teach them. You could even link to Matt's documentation pages that reference the parts of this process.

Comment thread README.rst
Comment thread virtual_site.py Outdated
Comment thread virtual_site.py
Comment thread virtual_site.py Outdated
Comment thread virtual_site.py Outdated
Comment thread virtual_site.py Outdated
@jashan-lco jashan-lco merged commit c6c39f6 into main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants