perf: optimize full-text benchmark hot paths#1116
Open
jmk640 wants to merge 3 commits into
Open
Conversation
|
|
LINxiansheng
marked this pull request as ready for review
July 18, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOKENIZE()results within the expression contextMATCHusage and bypass relevance computation when the score is not consumed, while retaining score calculation for projections, comparisons, ordering, shared expressions, and boolean modeMotivation
The FTS benchmark spends substantial time in parser setup and token-loop allocation, BM25 work for queries that only need document membership, and repeated expression setup during index construction. These changes target those paths independently while preserving token output, match semantics, and relevance behavior whenever the score is observable.
Validation
git diff --check origin/vldb_2026...HEADunittest/storage/fts/test_ft_parser.cppBenchmarking
Full
fts_large_bench.shbefore/after measurements are still required on the benchmark environment. Please keep this PR in draft until correctness regression tests and five-run median performance measurements are complete.