Skip to content

External id support#486

Open
PetrKubes97 wants to merge 2 commits into
oddbit:mainfrom
PetrKubes97:external-id-support
Open

External id support#486
PetrKubes97 wants to merge 2 commits into
oddbit:mainfrom
PetrKubes97:external-id-support

Conversation

@PetrKubes97
Copy link
Copy Markdown

Hi, this is just a first draft with a bit more changes than necessary due to Flutter 3.44 warnings.

I can clean it up and send just the external_id change, if you want. :)

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@DennisAlund
Copy link
Copy Markdown
Member

DennisAlund commented May 29, 2026

Thanks @PetrKubes97! iOS side looks good.

Some change requests

  1. Android actually supports external_id too — there's an 11-arg setUserData(...) overload with externalId since v18.1.x,
    inside our [18.0,19.0) range. Issue #1239 perhaps just left open and forgotten.
  2. Drop the unrelated stuff. The Package.swift, plus the pubspec.lock bumps, .idea deletion, and test reformatting.
  3. No release notes or version bumps, skip the CHANGELOG entry and any version changes, I'll handle those at release.

Just the external_id change with Android wired up like iOS. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants