feat: rc support#231
Open
flying-sheep wants to merge 3 commits into
Open
Conversation
ofek
reviewed
Jun 12, 2026
ofek
left a comment
ofek
left a comment
Owner
There was a problem hiding this comment.
Thanks! Let's try running it to see the generated output.
Author
The generated output is exactly the same as running it without my change, as there are currently no rcs active. I ran it with betas and rcs though to demonstrate, which
|
Owner
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1b6aa21a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| response = httpx.get(RELEASES_URL, headers=headers, timeout=60, params={'page': page, 'per_page': 5}) | ||
| progress = Progress() | ||
| task = progress.add_task("Updating distributions...") | ||
| progress.start() |
There was a problem hiding this comment.
Starting Progress manually without a matching stop() leaves Rich's live display active when the generator finishes or raises, so running this script in an interactive terminal can leave the cursor hidden and terminal rendering state unrestored. Wrap the pagination loop in a with Progress() as progress: block or stop it in a finally clause.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn’t in any way discriminate the RCs, they just pop up in the list.
Testing by changing
!= 'rc'tonot in {'rc', 'b'}, I noticed that only for 3.15, betas popped up. Do they delete beta assets from old releases?Fixes #232