feat: support --version flag in lib/**/init.sh scripts#35
Merged
Conversation
Add a --version flag to all 13 lib/**/init.sh scripts so adventures can pin specific tool versions without modifying shared scripts. - Refactor for-loop arg parsing to while/shift to support value-bearing flags - Each script defaults to its previously hardcoded version (backward-compatible) - kubernetes/init.sh uses per-tool flags (--kind-version, --kubectl-version, etc.) - prometheus/init.sh applies mode-specific defaults (operator: 82.1.1, standalone: latest) - otel-collector/init.sh accepts --version for API consistency with a stderr warning - Fix pre-existing unquoted variable in argocd/init.sh (shellcheck SC2086) - Update new-adventure.sh template and contributing docs with --version examples Closes #28 Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
KatharinaSick
requested changes
Apr 7, 2026
Contributor
KatharinaSick
left a comment
KatharinaSick
left a comment
There was a problem hiding this comment.
Good work! Thanks a lot! 😊
…heck Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
KatharinaSick
previously approved these changes
Apr 14, 2026
Contributor
KatharinaSick
left a comment
KatharinaSick
left a comment
There was a problem hiding this comment.
Thank you! Both are just suggestions but also happy to merge as is 😊
…t CI regex - Replace hardcoded v3.2.0 with ARGOCD_VERSION placeholder in argocd kustomization.yaml resource URL so applying the manifests directly without going through init.sh fails intentionally - Update sed pattern in argocd/init.sh from v[^/]* to [^/]* to match the placeholder string correctly - Fix continuation-line skip in lint-init-versions.yaml: replace broken ERE regex with glob pattern *\ which correctly identifies backslash continuation lines in multi-line kubernetes/init.sh calls - Add explanatory comment to lint-init-versions.yaml explaining why the check exists alongside runtime --version validation Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
KatharinaSick
approved these changes
Apr 15, 2026
Contributor
KatharinaSick
left a comment
KatharinaSick
left a comment
There was a problem hiding this comment.
Looks great - thank you! 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a --version flag to all 13 lib/**/init.sh scripts so adventures can pin specific tool versions without modifying shared scripts.
Closes #28
What does this PR do?
Closes #
Type of PR
📝 Other