fix: remove redundant Home nav link, refine brand guidelines and font…#113
Merged
Conversation
… preloads - Drop Home NavLink from Navbar — logo link (aria-label="offon.dev") already serves as home link, removing the axe duplicate-link warning - Remove Inter 700 preload from root.tsx; no component uses font-bold on non-heading elements - Switch btn-inverse and btn-ghost-inverse from font-bold to font-semibold in index.css - Refactor BrandGuidelines asset cards to a unified card-with-footer pattern for logos, icon mark, Nyx, and OG image - Add JetBrains Mono 400/600 font preloads to the Brand Guidelines page Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
- Switch font-bold → font-semibold in StarterNudge and WalkthroughSection so no component relies on the unpreloaded Inter 700 weight - Remove dead `border` property from all three LOGO_CARDS entries (no longer consumed after the card layout refactor) - Use filter/join instead of string interpolation in DownloadBadgeGroup className - Drop the Bold (700) row from the FONT_WEIGHTS specimen and update the Inter label to 400-600 to match styleguide - Add role="img" to the Syne specimen div so aria-label is valid (fixes axe aria-prohibited-attr violation on /brand) Signed-off-by: Sinduri Guntupalli <sinduri.guntupalli@dynatrace.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… preloads
Type of change
featnew featurefixbug fixrefactorno behavior changedocs/chore/config/perf/style/security