Skip to content

fix: add meaningful alt text to primary navbar logo for SEO #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sinduri-g merged 1 commit into from
Jun 5, 2026
Merged

fix: add meaningful alt text to primary navbar logo for SEO #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Link } from "react-router";
import { Sun, Moon, Menu, X, ExternalLink } from "lucide-react";
import { NavLink } from "@/components/NavLink";
import { useTheme } from "@/hooks/useTheme";
import { COMMUNITY_URL } from "@/data/constants";
import { COMMUNITY_URL, SITE_NAME } from "@/data/constants";
import { cn } from "@/lib/utils";
const logoDark = `${import.meta.env.BASE_URL}brand/offon-logo-dark-color.svg`;
const logoLight = `${import.meta.env.BASE_URL}brand/offon-logo-light-mono.svg`;
Expand Down Expand Up @@ -129,7 +129,7 @@ export const Navbar = (): JSX.Element => {
<div className="mx-auto flex max-w-6xl items-center justify-between px-6 py-1.5">
<Link to="/" aria-label="offon.dev" className="logo-link flex items-center focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 rounded-sm">
{/* Dark logo is high-priority: it's visible in the default (dark) theme. Light logo uses auto priority since it's hidden until the user switches theme. */}
<img src={logoDark} alt="" aria-hidden="true" width={130} height={33} loading="eager" fetchPriority="high" className="h-8 dark:block hidden" />
<img src={logoDark} alt={SITE_NAME} width={130} height={33} loading="eager" fetchPriority="high" className="h-8 dark:block hidden" />
<img src={logoLight} alt="" aria-hidden="true" width={130} height={33} loading="eager" className="h-8 block dark:hidden" />
</Link>

Expand Down
6 changes: 5 additions & 1 deletion src/test/navbar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ describe("Navbar - logo", () => {
const logoLink = screen.getByRole("link", { name: "offon.dev" });
const imgs = logoLink.querySelectorAll("img");
expect(imgs).toHaveLength(2);
expect(imgs[0].getAttribute("aria-hidden")).toBe("true");
// Dark logo: meaningful alt text for SEO, no aria-hidden per ACCESSIBILITY.md rule
expect(imgs[0].getAttribute("alt")).toBe("offon.dev");
expect(imgs[0].getAttribute("aria-hidden")).toBeNull();
// Light logo: decorative (dark logo carries the alt), aria-hidden required
expect(imgs[1].getAttribute("alt")).toBe("");
expect(imgs[1].getAttribute("aria-hidden")).toBe("true");
});

Expand Down
Loading