Nullable Reference Types#5
Open
TheConstructor wants to merge 1 commit into
Open
Conversation
TheConstructor
force-pushed
the
feature/nullable-reference-types
branch
from
d91ef4e to
54048c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Nullable Reference Types & annotations to the provided sources. Added some newer targets, too. This should be enough to get the benefits of NRTs in a consuming project, with still changing as little as possible.
NRTs have been introduced with C#8, which is why I raised the language level from 7. I believe, that this should be fine for about everyone consuming this library, and, given the fact that nobody cried for a new release in 6 years, for the remainder it may be ok to stick with the currently released version. That being said, I feel like you could drop some older TFMs and update the test-dependencies - it is however not directly related to this PR