Skip to content

Fixed broken testArraySearch() test #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayay merged 3 commits into from
Feb 13, 2026
Merged

Fixed broken testArraySearch() test #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e08336f
Replaced usage of assertEquals() with assertSame() in DropIns\StringT…
jdevinemt Feb 11, 2026
08035ff
Replaced usage of assertEquals() with assertSame() in DiSystem\Contai…
jdevinemt Feb 12, 2026
c48e1fa
Replaced deprecated implicit nullable parameter definition in DropIns…
jdevinemt Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/DiSystem/ContainerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function testGet_invalidArgument(): void
public function testGetConfiguration(): void
{
$diContainer = new Container();
$this->assertEquals([], $diContainer->getConfiguration());
$this->assertSame([], $diContainer->getConfiguration());

$localTestClass = new class () implements DebugMode {
public function isEnabled(): bool
Expand All @@ -100,7 +100,7 @@ public function isEnabled(): bool
};

$diContainer = new Container([DebugMode::class => get_class($localTestClass)]);
$this->assertEquals([DebugMode::class => get_class($localTestClass)], $diContainer->getConfiguration());
$this->assertSame([DebugMode::class => get_class($localTestClass)], $diContainer->getConfiguration());
$this->assertInstanceOf(get_class($localTestClass), $diContainer->get(DebugMode::class));
}
}
2 changes: 1 addition & 1 deletion tests/DropIns/RecursionInnerValue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class RecursionInnerValue

private $outerValue;

public function __construct(bool $bool, RecursionOuterValue $outerValue = null)
public function __construct(bool $bool, ?RecursionOuterValue $outerValue = null)
{
$this->bool = $bool;
$this->outerValue = $outerValue;
Expand Down
34 changes: 17 additions & 17 deletions tests/DropIns/StringToNumberComparisonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,17 @@ public function testNe(): void

public function testSpaceship(): void
{
$this->assertEquals(0, StringToNumberComparison::spaceship(0, 'a'));
$this->assertEquals(1, StringToNumberComparison::spaceship('0.10', 0));
$this->assertEquals(-1, StringToNumberComparison::spaceship(0, '0.10'));
$this->assertSame(0, StringToNumberComparison::spaceship(0, 'a'));
$this->assertSame(1, StringToNumberComparison::spaceship('0.10', 0));
$this->assertSame(-1, StringToNumberComparison::spaceship(0, '0.10'));
}

public function testSpaceship_WithTrailingWhitespace(): void
{
$this->assertEquals(1, StringToNumberComparison::spaceship('1 ', '1'));
$this->assertEquals(-1, StringToNumberComparison::spaceship('1', '1 '));
$this->assertEquals(0, StringToNumberComparison::spaceship('1', '1'));
$this->assertEquals(0, StringToNumberComparison::spaceship('1 ', '1 '));
$this->assertSame(1, StringToNumberComparison::spaceship('1 ', '1'));
$this->assertSame(-1, StringToNumberComparison::spaceship('1', '1 '));
$this->assertSame(0, StringToNumberComparison::spaceship('1', '1'));
$this->assertSame(0, StringToNumberComparison::spaceship('1 ', '1 '));
}

public function testInArray(): void
Expand Down Expand Up @@ -202,7 +202,7 @@ public function testInArray_strict(): void

public function testArraySearch(): void
{
$this->assertEquals(0, StringToNumberComparison::arraySearch('a', [0], false));
$this->assertSame(0, StringToNumberComparison::arraySearch('a', [0], false));
}

public function testArraySearch_strict(): void
Expand All @@ -212,20 +212,20 @@ public function testArraySearch_strict(): void

public function testArrayKeys(): void
{
$this->assertEquals([0 => 0], StringToNumberComparison::arrayKeys([0, 1, 2], 'a', false));
$this->assertEquals([0 => 0], StringToNumberComparison::arrayKeys([0, 1, 2], '0', false));
$this->assertSame([0 => 0], StringToNumberComparison::arrayKeys([0, 1, 2], 'a', false));
$this->assertSame([0 => 0], StringToNumberComparison::arrayKeys([0, 1, 2], '0', false));

$this->assertEquals(
$this->assertSame(
[0 => 0, 1 => 1, 2 => 2],
StringToNumberComparison::arrayKeys([0, 0, 0], 'a', false)
);
}

public function testArrayKeys_strict(): void
{
$this->assertEquals([], StringToNumberComparison::arrayKeys([0, 1, 2], 'a', true));
$this->assertEquals([], StringToNumberComparison::arrayKeys([0, 1, 2], '0', true));
$this->assertEquals([], StringToNumberComparison::arrayKeys([0, 0, 0], 'a', true));
$this->assertSame([], StringToNumberComparison::arrayKeys([0, 1, 2], 'a', true));
$this->assertSame([], StringToNumberComparison::arrayKeys([0, 1, 2], '0', true));
$this->assertSame([], StringToNumberComparison::arrayKeys([0, 0, 0], 'a', true));
}

public function testEq_recursionDoesntMatch(): void
Expand Down Expand Up @@ -254,14 +254,14 @@ public function testEq_recursionDoesntMatch(): void
$this->assertFalse(StringToNumberComparison::eq($innerConfig1, $innerConfig2));
$this->fail(RuntimeException::class . ' expected!');
} catch (RuntimeException $e) {
$this->assertEquals('Recursion limit of 180 was reached!', $e->getMessage());
$this->assertSame('Recursion limit of 180 was reached!', $e->getMessage());
}

try {
$this->assertTrue(StringToNumberComparison::ne($innerConfig1, $innerConfig2));
$this->fail(RuntimeException::class . ' expected!');
} catch (RuntimeException $e) {
$this->assertEquals('Recursion limit of 180 was reached!', $e->getMessage());
$this->assertSame('Recursion limit of 180 was reached!', $e->getMessage());
}

StaticDI::reset();
Expand Down Expand Up @@ -463,7 +463,7 @@ public function testCharacteristics(): void
$readableLeft = $this->getHumanReadableRepresentation($lhs);
$readableRight = $this->getHumanReadableRepresentation($rhs);

$this->assertEquals(
$this->assertSame(
$native,
$computed,
$cbComputed
Expand Down