Skip to content

[FVM] Remove unused error return from MeteringResult#8605

Open
janezpodhostnik wants to merge 1 commit into
masterfrom
janez/metering-result-no-error
Open

[FVM] Remove unused error return from MeteringResult#8605
janezpodhostnik wants to merge 1 commit into
masterfrom
janez/metering-result-no-error

Conversation

@janezpodhostnik

@janezpodhostnik janezpodhostnik commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

environment.Meter.MeteringResult() never returned a non-nil error in any implementation. This removes the error return from the interface, all implementations, and callers (including ProcedureOutput.PopulateEnvironmentValues, which became infallible as a result).

@janezpodhostnik
janezpodhostnik requested a review from a team as a code owner July 10, 2026 12:57
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4cc4c76-0709-4802-a6fa-36e0d7858084

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch janez/metering-result-no-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janezpodhostnik janezpodhostnik changed the title Remove unused error return from MeteringResult [FVM] Remove unused error return from MeteringResult Jul 10, 2026
Base automatically changed from janez/metering-cleanup to master July 17, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants