Docker bridge to act as main interface for lan,static host ip, assert revert namespace of wlan0#14
Open
hllhll wants to merge 5 commits into
Open
Docker bridge to act as main interface for lan,static host ip, assert revert namespace of wlan0#14hllhll wants to merge 5 commits into
hllhll wants to merge 5 commits into
Conversation
added 3 commits
October 10, 2020 15:19
- On bridge mode, the host will not get it's IP from OpenWrt, Rather it would be the static IP allocated by docker bridge (usually .1)
…cript ends. This makes sure it happens.
oofnikj
reviewed
Oct 11, 2020
Comment on lines
+48
to
+50
| echo "* Rolling back ip address for main if" | ||
| sudo service dhcpcd start | ||
| sudo dhclient -r |
Owner
There was a problem hiding this comment.
-
I'm not sure I understand the reason why this is necessary in your case.
-
While
dhcpcdis usually run as a separate service on Raspberry Pi OS, this is not the case for other intended targets, so I'd rather add some checks to this first.
Also, I would prefer not to add an additional dependency on dhclient if we are already using dhcpcd. They are not the same thing.
Owner
|
Hi, thanks for opening this PR. I've added a couple of inline comments. I think making WAN optional and the WiFi namespace commits are unrelated issues, so it would be best to open them as separate PRs. |
added 2 commits
November 10, 2020 09:39
…ities to the host, assign name for the lan interface bridge, some notes...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issues I encountered in #12
and also wlan0 would not return to host stack occasionally, so I've added it explicitly.