This repository was archived by the owner on Feb 21, 2023. It is now read-only.
Feature/school related models#29
Open
florian-lefebvre wants to merge 2 commits into
Open
Conversation
MRakox
suggested changes
Nov 12, 2022
| public name: string | ||
|
|
||
| @jsonColumn() | ||
| public contact: SchoolContact |
Contributor
There was a problem hiding this comment.
it would be better to have another model for the contact information with a relation to the school (hasOne + belongsTo)
Contributor
Author
There was a problem hiding this comment.
I was too lazy I have to admit 😅 I will do this thx
| public contact: SchoolContact | ||
|
|
||
| @jsonColumn() | ||
| public address: SchoolAddress |
Contributor
There was a problem hiding this comment.
same - it would be better to have another model for the adress with a relation to the school (hasOne + belongsTo)
Contributor
|
I forgot to add it in the review but auto-generated timestamps columns seems useless for some models ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.