Repository navigation
fix: flush grouped output after spawn errors - #634
Merged
gustavohenke merged 1 commit intoOct 24, 2026
Merged
gustavohenke merged 1 commit into
gustavohenke merged 1 commit into
Conversation
gustavohenke
approved these changes
Oct 24, 2026
gustavohenke
left a comment
Member
There was a problem hiding this comment.
Makes sense, thanks Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
group: true, output from later commands can be lost when a middle command fails to spawn before the first command finishes. For example, run a slow command, a command with a nonexistentcwd, and a command that immediately prints a message. The final message remains buffered even after all processes finish.Commandpreserves itserroredstate after the close event. Treat that state as finished when advancing grouped output, just as forexited. The regression verifies ordered flushing of both the spawn error and the later command's output, with no remaining buffered text.Validation:
ctrlc-wrapper@0.0.5only maps x64 and ia32, producingCannot find module 'ctrlc-wrapper-windows-undefined/start.exe'before application execution.AI disclosure: OpenAI Codex (GPT-6) found and reproduced the bug, implemented the patch and regression, performed the self-review, ran the reported checks, and wrote this description. No independent human review is claimed.