Skip to content

chore: remove cdktf from tests#277

Draft
jsteinich wants to merge 7 commits into
open-constructs:mainfrom
jsteinich:cdktf_test_removal
Draft

chore: remove cdktf from tests#277
jsteinich wants to merge 7 commits into
open-constructs:mainfrom
jsteinich:cdktf_test_removal

Conversation

@jsteinich

Copy link
Copy Markdown
Contributor

Related issue

Fixes #8

Description

  • Removes cdktf from the provider x command integration tests and instead tests using cdktn.
  • Adds a way to fake the cdktn version for testing purposes so that we can test against the branch built code rather than a previously released version.
  • Fixes an issue with C# package search.

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

Comment thread .prettierignore
packages/@cdktn/cli-core/src/test/lib/execution-logs.test.ts

packages/cdktf-cli/templates/*/cdktf.json
packages/cdktn-clie/templates/*/cdktf.json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
packages/cdktn-clie/templates/*/cdktf.json
packages/cdktn-cli/templates/*/cdktf.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit cli provider commands integration tests

2 participants