Skip to content

add forceResize checkbox to video thumbnail settings in admin bundle#82

Merged
solverat merged 3 commits into
1.xfrom
feat_video_force_resize
May 20, 2026
Merged

add forceResize checkbox to video thumbnail settings in admin bundle#82
solverat merged 3 commits into
1.xfrom
feat_video_force_resize

Conversation

@solverat
Copy link
Copy Markdown
Contributor

@solverat solverat commented May 20, 2026

See open-dxp/opendxp#96

I also HAD to rebrush the video js class because of reasons. For CR only use this commit: 86b088b

Clean-Up JS Structure Commit: 2fee74e

@solverat solverat added this to the 1.3.3 milestone May 20, 2026
@solverat solverat self-assigned this May 20, 2026
@solverat solverat added the enhancement New feature or request label May 20, 2026
@solverat solverat requested a review from benwalch May 20, 2026 08:06
@solverat solverat requested review from scrummer and removed request for benwalch May 20, 2026 09:11
Copy link
Copy Markdown
Member

@scrummer scrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new items.js needs to be imported here. After the import is added it should be fine and you're good to merge.
(Otherwise opendxp.settings.videothumbnail is always an empty object)

@solverat solverat merged commit 9da5235 into 1.x May 20, 2026
13 checks passed
@solverat solverat deleted the feat_video_force_resize branch May 20, 2026 11:00
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants