Skip to content

fix: multiprovider parity gaps with JS SDK reference (#1882) #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jonathannorris wants to merge 3 commits into
base: main
Choose a base branch
from

fix: address review feedback for multiprovider parity

58843b2
Select commit
Loading
Failed to load commit list.
Draft

fix: multiprovider parity gaps with JS SDK reference (#1882) #1897

fix: address review feedback for multiprovider parity
58843b2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 16, 2026 in 16s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 178 in src/main/java/dev/openfeature/sdk/multiprovider/ComparisonStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZz35pNXrZnDbgCwQ1r2&open=AZz35pNXrZnDbgCwQ1r2&pullRequest=1897

Check warning on line 627 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 114 to 64, Complexity from 17 to 14, Nesting Level from 4 to 2, Number of Variables from 28 to 6. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZz35pRFrZnDbgCwQ1r6&open=AZz35pRFrZnDbgCwQ1r6&pullRequest=1897

Check failure on line 110 in src/main/java/dev/openfeature/sdk/multiprovider/ComparisonStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZz35pNXrZnDbgCwQ1r1&open=AZz35pNXrZnDbgCwQ1r1&pullRequest=1897

Check warning on line 664 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Ensure this "Optional" could never be null and remove this null-check. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZz35pRFrZnDbgCwQ1r4&open=AZz35pRFrZnDbgCwQ1r4&pullRequest=1897

Check warning on line 693 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZz35pRFrZnDbgCwQ1r3&open=AZz35pRFrZnDbgCwQ1r3&pullRequest=1897

Check failure on line 627 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 29 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZz35pRFrZnDbgCwQ1r5&open=AZz35pRFrZnDbgCwQ1r5&pullRequest=1897
View more details on SonarQubeCloud