Skip to content

chore: resolve open dependabot security alerts#165

Closed
jonathannorris wants to merge 5 commits into
mainfrom
fix/dependabot-alerts
Closed

chore: resolve open dependabot security alerts#165
jonathannorris wants to merge 5 commits into
mainfrom
fix/dependabot-alerts

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

Summary

  • Resolved all open Dependabot security alerts by bumping addressable to 2.9.0 and json to 2.19.4 across openfeature-flagsmith-provider, openfeature-go-feature-flag-provider, and openfeature-meta_provider

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions in several Gemfile.lock files across different providers. The reviewer identified multiple critical issues: the specified Bundler version (4.0.10) is invalid as it has not been released, and the versions for the 'public_suffix' (7.0.5) and 'json' (2.19.4) gems do not exist on RubyGems, which will lead to build failures.

Comment thread providers/openfeature-flagsmith-provider/Gemfile.lock Outdated
Comment thread providers/openfeature-go-feature-flag-provider/Gemfile.lock Outdated
Comment thread providers/openfeature-go-feature-flag-provider/Gemfile.lock Outdated
Comment thread providers/openfeature-meta_provider/Gemfile.lock
Comment thread providers/openfeature-meta_provider/Gemfile.lock Outdated
@jonathannorris
Copy link
Copy Markdown
Member Author

The test_flagd_provider failures are pre-existing and unrelated to this PR — the flagd provider lockfile is unchanged. The failing test checks fractional targeting output for the color-palette-experiment flag, and targeting key "1234" now resolves to #4b5563 (grey) instead of the expected #b91c1c (red). The last passing run was April 1st, so this breakage predates this PR. Looks like it's related to the fractional evaluation hashing change tracked in #73.

- addressable 2.8.7/2.8.9 -> 2.9.0 (high, Dependabot alert 34, 35)
- json 2.19.0 -> 2.19.4 (high, Dependabot alert 29)

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
- addressable 2.8.7/2.8.9 -> 2.9.0 (high, Dependabot alert 34, 35)
- json 2.19.0 -> 2.19.4 (high, Dependabot alert 29)

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris force-pushed the fix/dependabot-alerts branch from d97ccc0 to 084fe56 Compare May 19, 2026 15:13
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
…ckfile

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
jonathannorris added a commit that referenced this pull request Jun 2, 2026
…r flagd v0.15.4 (#166)

## Summary

- Updates `color-palette-experiment` fractional targeting test
expectations to match bucketing behavior in flagd `v0.15.4`
- The fractional evaluator changed to high-precision integer arithmetic
(`(hash * totalWeight) >> 32`), which rebucketed all users — tracked in
#73
- Expected values verified by running the exact `twmb/murmur3` +
`distributeValue` algorithm from flagd's source at `core/v0.15.4`
- Replaced targeting keys with ones that resolve to all four distinct
variants (red, blue, green, grey), so the test validates fractional
bucketing rather than falling through to the default
- Originally identified as a pre-existing failure in #165

Also bumps `BUNDLED WITH` in the otel-hook `Gemfile.lock` from 2.7.1 to
4.0.11. A Ruby 4.1dev commit (between May 4–12) made
`Pathname::SEPARATOR_PAT` private, breaking bundler 2.7.1's vendored
thor. Bundler 4.0.0+ includes the fix (ruby/rubygems#9056).

---------

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants