Add default split key#193
Merged
Merged
Conversation
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Member
Author
|
@aaronchongth ci_linux was failing so I added |
aaronchongth
requested changes
May 22, 2026
| run: | | ||
| rm -rf target/ | ||
| cargo test --workspace -F=maximal | ||
| BUILD_FRONTEND=1 cargo test --workspace -F=maximal |
Member
There was a problem hiding this comment.
sorry for the back and forth even with these small changes, the error in the CI about BUILD_FRONTNED was prompting the user to run cd diagram-editor && BUILD_FRONTEND=1 cargo build which will update the binary blob or lockfile, that then needs to be committed as well. We shouldn't have this step in the CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #183 and as discussed during PMC meetings, this PR adds a default split key
unnamed_keyso users know to edit the key string on the edge.