Add setEnabledProtocols option to OTLP exporter builders#8610
Conversation
|
| ssl.trustManager(clientCertificate.certificate()); | ||
| // Restrict server to TLS 1.2+ so enabledProtocols tests are meaningful | ||
| // regardless of SSL backend (JDK TLS or BoringSSL via netty-tcnative). | ||
| ssl.protocols("TLSv1.2", "TLSv1.3"); |
There was a problem hiding this comment.
I was happy to see a nearly identical API from armeria
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8610 +/- ##
=========================================
Coverage 91.63% 91.63%
- Complexity 10326 10350 +24
=========================================
Files 1013 1013
Lines 27295 27356 +61
Branches 3205 3217 +12
=========================================
+ Hits 25011 25069 +58
- Misses 1558 1559 +1
- Partials 726 728 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull request dashboard statusStatus: Waiting on @jack-berg to address or respond to review feedback. Top-level feedback waiting on the author: Please give each review feedback item a clear outcome: link to the commit that addresses it, explain why no change is needed, or ask a follow-up question. |
|
Hey @jack-berg, thanks for the detailed analysis. I had one question about test coverage: is there a test that verifies the actual motivating scenario from #7573 — successfully reaching a real TLSv1/TLSv1.1-only server with enabledProtocols set and the JVM floor opened? As written, I ran into a related issue testing this in my PR: I just wanted to confirm whether that was the reasoning, or if I missed an existing test covering it. |
Fixes #7573