Include aggregation temporality in LoggingMetricExporter toString#8623
Draft
thswlsqls wants to merge 1 commit into
Draft
Include aggregation temporality in LoggingMetricExporter toString#8623thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8623 +/- ##
============================================
- Coverage 91.63% 91.60% -0.03%
- Complexity 10326 10343 +17
============================================
Files 1013 1013
Lines 27295 27352 +57
Branches 3205 3215 +10
============================================
+ Hits 25011 25057 +46
- Misses 1558 1567 +9
- Partials 726 728 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8622
Description
LoggingMetricExporter.toString()returned the constant"LoggingMetricExporter{}", socreate(DELTA)and the defaultcreate()(CUMULATIVE) printed identically, hiding this exporter's only setting.OpenTelemetrySdk.toString()prints the meter provider, andPeriodicMetricReader.toString()appends"exporter=" + exporter.MetricExporterimplementations that overridetoString()(OtlpGrpcMetricExporter,OtlpHttpMetricExporter,OtlpStdoutMetricExporter) already print their temporality.StringJoiner, since there is a single field — the form used elsewhere for single-fieldtoString()(e.g.SdkMeter,SdkObservableInstrument).Testing done
LoggingMetricExporterTest#stringRepresentationto assert thatcreate()printsCUMULATIVEandcreate(DELTA)printsDELTA; it fails against the old constant../gradlew :exporters:logging:check --rerun-tasks— 15 tests passed.toString()signature unchanged), so no apidiff update.