Skip to content

Log the exception when a gRPC response frame is invalid #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Draft

Log the exception when a gRPC response frame is invalid #8626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...http/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ private void handleResponse(Response response, Consumer<GrpcResponse> onResponse
compressed = body.source().readByte() != 0;
body.source().skip(4); // message length — we bound reads by EOF instead
} catch (IOException e) {
logger.log(Level.FINE, "Invalid gRPC response frame");
logger.log(Level.FINE, "Invalid gRPC response frame", e);
onResponse.accept(
ImmutableGrpcResponse.create(grpcStatus(response), grpcMessage(response), new byte[0]));
return;
Expand Down
Loading